diff --git a/core/client/app/components/gh-spin-button.js b/core/client/app/components/gh-spin-button.js index f487964c9c..5eda235fc1 100644 --- a/core/client/app/components/gh-spin-button.js +++ b/core/client/app/components/gh-spin-button.js @@ -8,7 +8,7 @@ export default Ember.Component.extend({ autoWidth: true, // Disable Button when isLoading equals true - attributeBindings: ['disabled'], + attributeBindings: ['disabled', 'type', 'tabindex'], // Must be set on the controller disabled: Ember.computed.equal('submitting', true), diff --git a/core/client/app/components/gh-trim-focus-input.js b/core/client/app/components/gh-trim-focus-input.js index f1627bf7f6..5c8cc4c1de 100644 --- a/core/client/app/components/gh-trim-focus-input.js +++ b/core/client/app/components/gh-trim-focus-input.js @@ -2,7 +2,7 @@ import Ember from 'ember'; /*global device*/ var TrimFocusInput = Ember.TextField.extend({ focus: true, - + classNames: 'gh-input', attributeBindings: ['autofocus'], autofocus: Ember.computed(function () { diff --git a/core/client/app/templates/components/gh-editor-save-button.hbs b/core/client/app/templates/components/gh-editor-save-button.hbs index b62dc45e92..40608cccea 100644 --- a/core/client/app/templates/components/gh-editor-save-button.hbs +++ b/core/client/app/templates/components/gh-editor-save-button.hbs @@ -1,4 +1,4 @@ -{{gh-spin-button type="button" classNameBindings=":btn :btn-sm :js-publish-button isDangerous:btn-red:btn-blue" action="save" buttonText=saveText submitting=submitting}} +{{#gh-spin-button type="button" classNameBindings=":btn :btn-sm :js-publish-button isDangerous:btn-red:btn-blue" action="save" submitting=submitting}}{{saveText}}{{/gh-spin-button}} {{#gh-dropdown-button dropdownName="post-save-menu" classNameBindings=":btn :btn-sm isDangerous:btn-red:btn-blue btnopen:active :dropdown-toggle :up"}} diff --git a/core/client/app/templates/modals/signin.hbs b/core/client/app/templates/modals/signin.hbs index e60fb696a7..ad6938f397 100644 --- a/core/client/app/templates/modals/signin.hbs +++ b/core/client/app/templates/modals/signin.hbs @@ -5,7 +5,7 @@
{{input class="gh-input password" type="password" placeholder="Password" name="password" value=password}}
- {{gh-spin-button class="btn btn-blue" type="submit" action="validateAndAuthenticate" submitting=submitting buttonText="Log in"}} + {{#gh-spin-button class="btn btn-blue" type="submit" action="validateAndAuthenticate" submitting=submitting}}Log in{{/gh-spin-button}} {{/gh-modal-dialog}} diff --git a/core/client/app/templates/reset.hbs b/core/client/app/templates/reset.hbs index f65736aeaf..65d4ba27ed 100644 --- a/core/client/app/templates/reset.hbs +++ b/core/client/app/templates/reset.hbs @@ -9,7 +9,7 @@ {{gh-input type="password" name="ne2password" placeholder="Confirm Password" class="password" autocorrect="off" autofocus="autofocus" value=ne2Password}} {{/gh-form-group}} - {{gh-spin-button class="btn btn-blue btn-block" type="submit" submitting=submitting buttonText="Reset Password" autoWidth=false}} + {{#gh-spin-button class="btn btn-blue btn-block" type="submit" submitting=submitting autoWidth="false"}}Reset Password{{/gh-spin-button}}

{{{flowErrors}}}

diff --git a/core/client/app/templates/settings/code-injection.hbs b/core/client/app/templates/settings/code-injection.hbs index 8273e13233..6e8d86ee64 100644 --- a/core/client/app/templates/settings/code-injection.hbs +++ b/core/client/app/templates/settings/code-injection.hbs @@ -2,7 +2,7 @@
{{#gh-view-title openMobileMenu="openMobileMenu"}}Code Injection{{/gh-view-title}}
- {{gh-spin-button type="button" class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}} + {{#gh-spin-button class="btn btn-blue" action="save" submitting=submitting}}Save{{/gh-spin-button}}
diff --git a/core/client/app/templates/settings/general.hbs b/core/client/app/templates/settings/general.hbs index 27d7624991..35782d8ce7 100644 --- a/core/client/app/templates/settings/general.hbs +++ b/core/client/app/templates/settings/general.hbs @@ -2,7 +2,7 @@
{{#gh-view-title openMobileMenu="openMobileMenu"}}General{{/gh-view-title}}
- {{gh-spin-button type="button" class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}} + {{#gh-spin-button class="btn btn-blue" action="save" submitting=submitting}}Save{{/gh-spin-button}}
diff --git a/core/client/app/templates/settings/labs.hbs b/core/client/app/templates/settings/labs.hbs index 917aacfde1..8494c7c8b7 100644 --- a/core/client/app/templates/settings/labs.hbs +++ b/core/client/app/templates/settings/labs.hbs @@ -37,7 +37,7 @@
- {{gh-spin-button type="button" id="sendtestemail" class="btn btn-blue" action="sendTestEmail" buttonText="Send" submitting=submitting}} + {{#gh-spin-button id="sendtestemail" class="btn btn-blue" action="sendTestEmail" submitting=submitting}}Send{{/gh-spin-button}}

Sends a test email to your address.

diff --git a/core/client/app/templates/settings/navigation.hbs b/core/client/app/templates/settings/navigation.hbs index c8dcb6533c..37de0b354c 100644 --- a/core/client/app/templates/settings/navigation.hbs +++ b/core/client/app/templates/settings/navigation.hbs @@ -2,7 +2,7 @@
{{#gh-view-title openMobileMenu="openMobileMenu"}}Navigation{{/gh-view-title}}
- {{gh-spin-button type="button" class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}} + {{#gh-spin-button class="btn btn-blue" action="save" submitting=submitting}}Save{{/gh-spin-button}}
diff --git a/core/client/app/templates/setup/three.hbs b/core/client/app/templates/setup/three.hbs index ef190ed6bb..af73113fce 100644 --- a/core/client/app/templates/setup/three.hbs +++ b/core/client/app/templates/setup/three.hbs @@ -11,7 +11,7 @@ {{gh-error-message errors=errors property="users"}} -{{gh-spin-button type="button" classNameBindings=":btn :btn-default :btn-lg :btn-block buttonClass" action="invite" buttonText=buttonText submitting=submitting autoWidth=false}} +{{#gh-spin-button classNameBindings=":btn :btn-default :btn-lg :btn-block buttonClass" action="invite" submitting=submitting autoWidth="false"}}{{buttonText}}{{/gh-spin-button}} {{/gh-form-group}} - {{gh-spin-button class="login btn btn-blue btn-block" type="submit" tabindex="3" buttonText="Sign in" submitting=loggingIn autoWidth=false}} + {{#gh-spin-button class="login btn btn-blue btn-block" type="submit" tabindex="3" submitting=loggingIn autoWidth="false"}}Sign in{{/gh-spin-button}}

{{{flowErrors}}}

diff --git a/core/client/app/templates/signup.hbs b/core/client/app/templates/signup.hbs index 934b8d12af..ae53111f87 100644 --- a/core/client/app/templates/signup.hbs +++ b/core/client/app/templates/signup.hbs @@ -15,34 +15,27 @@ {{#gh-form-group errors=model.errors property="email"}} - {{gh-input type="email" name="email" placeholder="Eg. john@example.com" class="gh-input" enter=(action "signup") disabled=true autocorrect="off" value=model.email focusOut=(action "handleEmail")}} + {{gh-input type="email" name="email" placeholder="Eg. john@example.com" enter=(action "signup") disabled="disabled" autocorrect="off" value=model.email focusOut=(action "handleEmail")}} {{gh-error-message errors=model.errors property="email"}} {{/gh-form-group}} {{#gh-form-group errors=model.errors property="name"}} - {{gh-input type="text" name="name" placeholder="Eg. John H. Watson" class="gh-input" enter=(action "signup") autofocus="autofocus" autocorrect="off" value=model.name focusOut=(action "validate" "name")}} + {{gh-trim-focus-input tabindex="1" type="text" name="name" placeholder="Eg. John H. Watson" enter=(action "signup") autocorrect="off" value=model.name focusOut=(action "validate" "name")}} {{gh-error-message errors=model.errors property="name"}} {{/gh-form-group}} {{#gh-form-group errors=model.errors property="password"}} - {{input class="gh-input" type="password" name="password" autofocus="autofocus" enter=(action "signup") autocorrect="off" value=model.password focusOut=(action "validate" "password")}} -
-
-
-
-
-
-
+ {{gh-input tabindex="2" type="password" name="password" enter=(action "signup") autocorrect="off" value=model.password focusOut=(action "validate" "password")}}
{{gh-error-message errors=model.errors property="password"}} {{/gh-form-group}} - {{gh-spin-button type="submit" class="btn btn-green btn-lg btn-block" action="signup" submitting=submitting buttonText="Create Account" autoWidth=false}} + {{#gh-spin-button tabindex="3" type="submit" class="btn btn-green btn-lg btn-block" action="signup" submitting=submitting autoWidth="false"}}Create Account{{/gh-spin-button}}

{{{flowErrors}}}

diff --git a/core/client/app/templates/team/user.hbs b/core/client/app/templates/team/user.hbs index a5c6ad35b7..421b334f9b 100644 --- a/core/client/app/templates/team/user.hbs +++ b/core/client/app/templates/team/user.hbs @@ -30,7 +30,7 @@ {{/if}} - {{gh-spin-button class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}} + {{#gh-spin-button class="btn btn-blue" action="save" submitting=submitting}}Save{{/gh-spin-button}}