0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00

Reduced number of hashing rounds during tests

- one of the reasons our tests are so slow is because we're running 10
  rounds of bcrypt hashing on shared hardware, nearly 300 times during
  the database tests
- we don't particularly care about password hash strength during tests
  so this commit reduces the number of rounds to 1 if we're running in a
  test environment
- this drops the time to produce an individual hash from ~140ms to ~3ms,
  saving us a lot of time overall
This commit is contained in:
Daniel Lockyer 2022-08-15 12:09:42 +02:00
parent fa6900b299
commit 0a68ea88fb

View file

@ -1,6 +1,13 @@
const bcrypt = require('bcryptjs');
let HASH_ROUNDS = 10;
if (process.env.NODE_ENV.startsWith('testing')) {
HASH_ROUNDS = 1;
}
module.exports.hash = async function hash(plainPassword) {
const salt = await bcrypt.genSalt();
const salt = await bcrypt.genSalt(HASH_ROUNDS);
return bcrypt.hash(plainPassword, salt);
};