Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Updated comment (#17718)

Browse source 
no issue

- added some more info to the comment
- found the actual issue that needed the admin p0 fix last night.
Updated the comment info block with a link to that issue.


<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at bcec294</samp>

Updated a comment in `members.js` to link to a possible NQL issue. This
helps explain the temporary fix for filtering members by labels with
parentheses.
This commit is contained in:
Ronald Langeveld 2023-08-15 10:45:09 +02:00 • committed by GitHub
parent e0ab167b94
commit 09bcc1f31a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/admin/app/controllers/members.js
View file

@ -238,9 +238,9 @@ export default class MembersController extends Controller {
getApiQueryObject({params, extraFilters = []} = {}) {
let {label, paidParam, searchParam, filterParam} = params ? params : this;
// NOTE: this is a temporary fix to help where the API isn't handling the parentheses correctly
// NOTE: this is a temporary fix to help where the API/NQL isn't handling the parentheses correctly
// It's potentially a deeper issue with NQL. This should be removed once the API is fixed.
// refs https://ghost.slack.com/archives/C05EQPTMEP7/p1692025845788769
// This could be related https://github.com/TryGhost/NQL/issues/16
if (filterParam) {
filterParam = this.refineFilterParam(filterParam);
}