Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Fixed loading 0th page of recommendations (#18116)

Browse source 
no issue

When the total numbers of pages was 0, the pagination hook would try to
load the 0th page which would cause an API error.
This commit is contained in:
Simon Backx 2023-09-13 15:46:18 +02:00 • committed by GitHub
parent 908e02c016
commit 0559c8ba64
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/admin-x-settings/src/hooks/usePagination.tsx
View file

@ -24,7 +24,7 @@ export const usePagination = ({limit, meta, page, setPage}: {meta?: Meta, limit:
if (meta) { if (meta) {
setPrevMeta(meta); setPrevMeta(meta);
if (meta.pagination.pages < page) { if (meta.pagination.pages > 0 && meta.pagination.pages < page) {
// We probably deleted an item when on the last page: go one page back automatically // We probably deleted an item when on the last page: go one page back automatically
setPage(meta.pagination.pages); setPage(meta.pagination.pages);
} }
@ -37,7 +37,7 @@ export const usePagination = ({limit, meta, page, setPage}: {meta?: Meta, limit:
pages: prevMeta?.pagination.pages ?? null, pages: prevMeta?.pagination.pages ?? null,
limit: prevMeta?.pagination.limit ?? limit, limit: prevMeta?.pagination.limit ?? limit,
total: prevMeta?.pagination.total ?? null, total: prevMeta?.pagination.total ?? null,
nextPage: () => setPage(Math.min(page + 1, prevMeta?.pagination.pages ?? page)), nextPage: () => setPage(Math.min(page + 1, prevMeta?.pagination.pages ? prevMeta.pagination.pages : page)),
prevPage: () => setPage(Math.max(1, page - 1)) prevPage: () => setPage(Math.max(1, page - 1))
}; };
}; };