Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Removed unused memberCount property passed to GhPublishmenu

Browse source 
refs https://github.com/TryGhost/Team/issues/1538

The memberCount property was not used, so I removed all related code and fetch.
This commit is contained in:
Simon Backx 2022-04-21 11:54:48 +02:00 • committed by Matt Hanley
parent 1beadb5304
commit 04aff7f51b
3 changed files with 3 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/admin/app/components/gh-publishmenu.js
View file

@ -295,10 +295,6 @@ export default Component.extend({
return true; return true;
}, },
updateMemberCount(count) {
this.memberCount = count;
},
publishFromShortcut() { publishFromShortcut() {
// trigger blur for inputs and textareas to trigger any actions // trigger blur for inputs and textareas to trigger any actions
// before attempting to save so we're saving after the result // before attempting to save so we're saving after the result

1
ghost/admin/app/components/modals/post-preview.hbs
View file

@ -25,7 +25,6 @@
@postStatus={{@data.post.status}} @postStatus={{@data.post.status}}
@saveTask={{@data.saveTask}} @saveTask={{@data.saveTask}}
@setSaveType={{@data.setEditorSaveType}} @setSaveType={{@data.setEditorSaveType}}
@memberCount={{@data.memberCount}}
@uiContext="preview" /> @uiContext="preview" />
{{/unless}} {{/unless}}
</header> </header>

12
ghost/admin/app/controllers/editor.js
View file

@ -8,7 +8,7 @@ import classic from 'ember-classic-decorator';
import config from 'ghost-admin/config/environment'; import config from 'ghost-admin/config/environment';
import isNumber from 'ghost-admin/utils/isNumber'; import isNumber from 'ghost-admin/utils/isNumber';
import moment from 'moment'; import moment from 'moment';
import {action, computed, get} from '@ember/object'; import {action, computed} from '@ember/object';
import {alias, mapBy} from '@ember/object/computed'; import {alias, mapBy} from '@ember/object/computed';
import {capitalize} from '@ember/string'; import {capitalize} from '@ember/string';
import {dropTask, enqueueTask, restartableTask, task, taskGroup, timeout} from 'ember-concurrency'; import {dropTask, enqueueTask, restartableTask, task, taskGroup, timeout} from 'ember-concurrency';
@ -277,8 +277,7 @@ export default class EditorController extends Controller {
post: this.post, post: this.post,
saveTask: this.saveTask, saveTask: this.saveTask,
hasDirtyAttributes: this.hasDirtyAttributes, hasDirtyAttributes: this.hasDirtyAttributes,
setEditorSaveType: this.setSaveType, setEditorSaveType: this.setSaveType
memberCount: this.memberCount
}); });
} }
@ -774,13 +773,6 @@ export default class EditorController extends Controller {
// load supplementel data such as the members count in the background // load supplementel data such as the members count in the background
@restartableTask *backgroundLoaderTask() { @restartableTask *backgroundLoaderTask() {
try {
let membersResponse = yield this.store.query('member', {limit: 1, filter: 'subscribed:true'});
this.set('memberCount', get(membersResponse, 'meta.pagination.total'));
} catch (error) {
this.set('memberCount', 0);
}
yield this.store.query('snippet', {limit: 'all'}); yield this.store.query('snippet', {limit: 'all'});
} }