From 02fe1591e5cf1a0f904f0b6e779dc0b9b922a204 Mon Sep 17 00:00:00 2001 From: Nazar Gargol Date: Tue, 3 Dec 2019 16:05:56 +0700 Subject: [PATCH] Fixed members acceptance test - The `await wait()` worked in combination with correct assertions --- ghost/admin/tests/acceptance/members-test.js | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/ghost/admin/tests/acceptance/members-test.js b/ghost/admin/tests/acceptance/members-test.js index 3eccf37d52..12f1ceac45 100644 --- a/ghost/admin/tests/acceptance/members-test.js +++ b/ghost/admin/tests/acceptance/members-test.js @@ -155,20 +155,12 @@ describe('Acceptance: Members', function () { await click('[data-test-button="save"]'); - // extra timeout needed for FF on Linux - sometimes it doesn't update - // quick enough, especially on Travis, and an extra wait() call - // doesn't help - await timeout(200); + await wait(); expect(find('.gh-member-basic-settings-form input[name="name"]').value, 'name has been preserved') .to.equal('New Name'); - - // disables email field after member has been created - // TODO: the commented out case should be valid, but it fails when run from headless - // expect(find('.gh-member-basic-settings-form input[name="email-disabled"]').disabled, 'makes sure email is disabled') - // .to.equal(true); - expect(find('.gh-member-basic-settings-form input[name="email"]').value, 'name has been preserved') - .to.equal('example@domain.com'); + expect(find('.gh-member-basic-settings-form input[name="email-disabled"]').disabled, 'makes sure email is disabled') + .to.equal(true); }); }); });