Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Removed useless comment

Browse source 
no issue

- Engines in theme's package json have no effect whatsoever on how Ghost instance runs.
This commit is contained in:
Naz 2022-05-17 16:08:19 +08:00 • committed by naz
parent 5c2ece9668
commit 0260ec5a64
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
test/integration/url_service.test.js
View file

@ -7,13 +7,6 @@ const configUtils = require('../utils/configUtils');
const models = require('../../core/server/models'); const models = require('../../core/server/models');
const UrlService = require('../../core/server/services/url/UrlService'); const UrlService = require('../../core/server/services/url/UrlService');
/**
* @NOTE
*
* If this test fails for you, you are probably modifying supported theme engines
* and thus should check if the there is a configuration added for the new API version
*
*/
describe('Integration: services/url/UrlService', function () { describe('Integration: services/url/UrlService', function () {
let urlService; let urlService;
@ -134,7 +127,7 @@ describe('Integration: services/url/UrlService', function () {
urlService = new UrlService(); urlService = new UrlService();
urlService.onRouterAddedType('unique-id-1', 'featured:true', 'posts', '/podcast/:slug/'); urlService.onRouterAddedType('unique-id-1', 'featured:true', 'posts', '/podcast/:slug/');
urlService.onRouterAddedType('unique-id-2', 'page:false', 'posts', '/collection/:year/:slug/'); urlService.onRouterAddedType('unique-id-2', 'type:post', 'posts', '/collection/:year/:slug/');
urlService.onRouterAddedType('unique-id-3', null, 'authors', '/persons/:slug/'); urlService.onRouterAddedType('unique-id-3', null, 'authors', '/persons/:slug/');
urlService.onRouterAddedType('unique-id-4', null, 'tags', '/category/:slug/'); urlService.onRouterAddedType('unique-id-4', null, 'tags', '/category/:slug/');
urlService.onRouterAddedType('unique-id-5', null, 'pages', '/:slug/'); urlService.onRouterAddedType('unique-id-5', null, 'pages', '/:slug/');
@ -160,7 +153,7 @@ describe('Integration: services/url/UrlService', function () {
it('getUrl', function () { it('getUrl', function () {
urlService.urlGenerators.forEach(function (generator) { urlService.urlGenerators.forEach(function (generator) {
if (generator.resourceType === 'posts' && generator.filter === 'page:false') { if (generator.resourceType === 'posts' && generator.filter === 'type:post') {
generator.getUrls().length.should.eql(2); generator.getUrls().length.should.eql(2);
} }