Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Added priority to webhook secret if present in env (#103)

Browse source 
no issue

- When debugging Stripe with using: `stripe listen \
  --forward-to http://ghost.local/members/webhooks/stripe/` this priority is nice to have so that Ghost process can be initialized using WEBHOOK_SECRET env variable
- It was not working in current form because Stripe recognized `ghost.local` as a valid domain and didn't throw any errors
- Removed unneeded secret assignment in a catch statement. It is redundant with the new implementation
This commit is contained in:
Naz Gargol 2019-11-25 13:15:28 +07:00 • committed by GitHub
parent 9da1a18770
commit 0149dd8f4d
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ghost/members-api/lib/stripe/index.js
View file

@ -62,10 +62,9 @@ module.exports = class StripePaymentProcessor {
'invoice.payment_failed' 'invoice.payment_failed'
] ]
}); });
this._webhookSecret = webhook.secret; this._webhookSecret = process.env.WEBHOOK_SECRET || webhook.secret;
} catch (err) { } catch (err) {
this.logging.warn(err); this.logging.warn(err);
this._webhookSecret = process.env.WEBHOOK_SECRET;
} }
debug(`Webhook secret set to ${this._webhookSecret}`); debug(`Webhook secret set to ${this._webhookSecret}`);
} catch (err) { } catch (err) {