From 00c2b7150277a350e78d524fa1cf98954b770931 Mon Sep 17 00:00:00 2001 From: Elena Baidakova Date: Wed, 14 Dec 2022 19:39:01 +0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20slug=20saving=20in=20edi?= =?UTF-8?q?tor=20(#16007)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refs TryGhost/Team#2294 - If user enter the slug name and then leave the post page, we should wait until the slug would be saved on backend. The problem can be reproduced with slow internet connection. --- ghost/admin/app/controllers/editor.js | 8 ++++++++ ghost/admin/app/controllers/lexical-editor.js | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/ghost/admin/app/controllers/editor.js b/ghost/admin/app/controllers/editor.js index 2ba04ed890..fb4a56f5c6 100644 --- a/ghost/admin/app/controllers/editor.js +++ b/ghost/admin/app/controllers/editor.js @@ -788,6 +788,14 @@ export default class EditorController extends Controller { this._koenig.cleanup(); } + // user can enter the slug name and then leave the post page, + // in such case we should wait until the slug would be saved on backend + if (this.updateSlugTask.isRunning) { + transition.abort(); + await this.updateSlugTask.last; + return transition.retry(); + } + let hasDirtyAttributes = this.hasDirtyAttributes; let state = post.getProperties('isDeleted', 'isSaving', 'hasDirtyAttributes', 'isNew'); diff --git a/ghost/admin/app/controllers/lexical-editor.js b/ghost/admin/app/controllers/lexical-editor.js index 2e113d078e..d4fcb6304e 100644 --- a/ghost/admin/app/controllers/lexical-editor.js +++ b/ghost/admin/app/controllers/lexical-editor.js @@ -791,6 +791,14 @@ export default class LexicalEditorController extends Controller { // this._koenig.cleanup(); // } + // user can enter the slug name and then leave the post page, + // in such case we should wait until the slug would be saved on backend + if (this.updateSlugTask.isRunning) { + transition.abort(); + await this.updateSlugTask.last; + return transition.retry(); + } + let hasDirtyAttributes = this.hasDirtyAttributes; let state = post.getProperties('isDeleted', 'isSaving', 'hasDirtyAttributes', 'isNew');