Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Fixed undefined in subcription confirmation screen

Browse source 
no refs

- We updated site plans to use `currency_symbol` instead of `currency`, but missed updating it here so the popup showed `undefined` for the new plan on confirmation screen
This commit is contained in:
Rish 2021-03-08 23:05:58 +05:30
parent 2e41b24240
commit 00485dc89b
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/portal/src/App.js
View file

@ -16,7 +16,7 @@ const DEV_MODE_DATA = {
showPopup: true,
site: Fixtures.site,
member: Fixtures.member.paid,
page: 'signup'
page: 'accountHome'
};
export default class App extends React.Component {
constructor(props) {

5
ghost/portal/src/components/pages/AccountPlanPage.js
View file

@ -5,7 +5,7 @@ import CloseButton from '../common/CloseButton';
import BackButton from '../common/BackButton';
import PlansSection from '../common/PlansSection';
import {getDateString} from '../../utils/date-time';
import {getMemberActivePlan, getMemberSubscription, getPlanFromSubscription, getSitePlans, getSubscriptionFromId, isPaidMember} from '../../utils/helpers';
import {formatNumber, getMemberActivePlan, getMemberSubscription, getPlanFromSubscription, getSitePlans, getSubscriptionFromId, isPaidMember} from '../../utils/helpers';
export const AccountPlanPageStyles = `
.gh-portal-accountplans-main {
@ -129,7 +129,8 @@ const PlanConfirmationSection = ({action, member, plan, type, brandColor, onConf
if (currentActivePlan.type !== plan.type) {
planStartDate = 'today';
}
const planStartMessage = `${plan.currency}${plan.price}/${plan.type} – Starting ${planStartDate}`;
const priceString = formatNumber(plan.price);
const planStartMessage = `${plan.currency_symbol}${priceString}/${plan.type} – Starting ${planStartDate}`;
if (type === 'changePlan') {
return (
<>