Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity
ghost/core/test/unit/models/permission_spec.js

57 lines
2 KiB
JavaScript
Raw Normal View History

Use bookshelf-relations for Permission model: roles refs https://github.com/TryGhost/Ghost/pull/9592 - we add bookshelf-relations step by step if we need it - with https://github.com/TryGhost/Ghost/pull/9592 we have rewritten the test env to use Bookshelf - this is important for our new url service - because the service is listening on model updates and updates the urls based on the model events - so with moving to Bookshelf, we need any easy way to add relations - the test env inserts test fixtures - it adds permissions and each permission get's roles attached - `models.Permission.add({roles: [...]})
2018-04-25 12:27:39 +02:00
const should = require('should'),
sinon = require('sinon'),
models = require('../../../server/models'),
testUtils = require('../../utils'),
Bumped sinon from 4.4.6 to 7.3.2 (#10400) refs #9389 - https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md Breaking changes for Ghost: - no need to create a sandbox anymore, each file get's it's own sandbox - just require sinon and use this sandbox - you can still create separate sandboxes with .createSandbox - reset single stubs: use .resetHistory instead of .reset This is a global replace for any sandbox creation. --- From https://sinonjs.org/releases/v7.2.3/sandbox/ > Default sandbox > Since sinon@5.0.0, the sinon object is a default sandbox. Unless you have a very advanced setup or need a special configuration, you probably want to just use that one.
2019-01-21 17:53:44 +01:00
configUtils = require('../../utils/configUtils');
Use bookshelf-relations for Permission model: roles refs https://github.com/TryGhost/Ghost/pull/9592 - we add bookshelf-relations step by step if we need it - with https://github.com/TryGhost/Ghost/pull/9592 we have rewritten the test env to use Bookshelf - this is important for our new url service - because the service is listening on model updates and updates the urls based on the model events - so with moving to Bookshelf, we need any easy way to add relations - the test env inserts test fixtures - it adds permissions and each permission get's roles attached - `models.Permission.add({roles: [...]})
2018-04-25 12:27:39 +02:00
describe('Unit: models/permission', function () {
before(function () {
models.init();
});
after(function () {
Bumped sinon from 4.4.6 to 7.3.2 (#10400) refs #9389 - https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md Breaking changes for Ghost: - no need to create a sandbox anymore, each file get's it's own sandbox - just require sinon and use this sandbox - you can still create separate sandboxes with .createSandbox - reset single stubs: use .resetHistory instead of .reset This is a global replace for any sandbox creation. --- From https://sinonjs.org/releases/v7.2.3/sandbox/ > Default sandbox > Since sinon@5.0.0, the sinon object is a default sandbox. Unless you have a very advanced setup or need a special configuration, you probably want to just use that one.
2019-01-21 17:53:44 +01:00
sinon.restore();
Removed knex mock (#9685) no issue - this mock eat already too much of my/our time - the idea of adding a knex mock was definitely a failed approach/try - it's too much to maintaince and have not found a module which does this already - we have to support any query format - this is too crazy - the idea was to use the knex mock for model unit tests, because if we want to unit test models we have to run through bookshelf, because the whole model layer depends on bookshelf e.g. events - for now we simply use the real database - we could use the sqlite3 memory mode, but that would mean every unit test runs on sqlite3 - something to consider for later e.g. run unit tests on one matrix - run the rest on another matrix for sqlite + mysql
2018-06-12 20:26:16 +02:00
configUtils.restore();
Use bookshelf-relations for Permission model: roles refs https://github.com/TryGhost/Ghost/pull/9592 - we add bookshelf-relations step by step if we need it - with https://github.com/TryGhost/Ghost/pull/9592 we have rewritten the test env to use Bookshelf - this is important for our new url service - because the service is listening on model updates and updates the urls based on the model events - so with moving to Bookshelf, we need any easy way to add relations - the test env inserts test fixtures - it adds permissions and each permission get's roles attached - `models.Permission.add({roles: [...]})
2018-04-25 12:27:39 +02:00
});
Removed knex mock (#9685) no issue - this mock eat already too much of my/our time - the idea of adding a knex mock was definitely a failed approach/try - it's too much to maintaince and have not found a module which does this already - we have to support any query format - this is too crazy - the idea was to use the knex mock for model unit tests, because if we want to unit test models we have to run through bookshelf, because the whole model layer depends on bookshelf e.g. events - for now we simply use the real database - we could use the sqlite3 memory mode, but that would mean every unit test runs on sqlite3 - something to consider for later e.g. run unit tests on one matrix - run the rest on another matrix for sqlite + mysql
2018-06-12 20:26:16 +02:00
before(testUtils.teardown);
Use bookshelf-relations for Permission model: roles refs https://github.com/TryGhost/Ghost/pull/9592 - we add bookshelf-relations step by step if we need it - with https://github.com/TryGhost/Ghost/pull/9592 we have rewritten the test env to use Bookshelf - this is important for our new url service - because the service is listening on model updates and updates the urls based on the model events - so with moving to Bookshelf, we need any easy way to add relations - the test env inserts test fixtures - it adds permissions and each permission get's roles attached - `models.Permission.add({roles: [...]})
2018-04-25 12:27:39 +02:00
Removed knex mock (#9685) no issue - this mock eat already too much of my/our time - the idea of adding a knex mock was definitely a failed approach/try - it's too much to maintaince and have not found a module which does this already - we have to support any query format - this is too crazy - the idea was to use the knex mock for model unit tests, because if we want to unit test models we have to run through bookshelf, because the whole model layer depends on bookshelf e.g. events - for now we simply use the real database - we could use the sqlite3 memory mode, but that would mean every unit test runs on sqlite3 - something to consider for later e.g. run unit tests on one matrix - run the rest on another matrix for sqlite + mysql
2018-06-12 20:26:16 +02:00
describe('add', function () {
beforeEach(testUtils.setup('roles'));
afterEach(testUtils.teardown);
Use bookshelf-relations for Permission model: roles refs https://github.com/TryGhost/Ghost/pull/9592 - we add bookshelf-relations step by step if we need it - with https://github.com/TryGhost/Ghost/pull/9592 we have rewritten the test env to use Bookshelf - this is important for our new url service - because the service is listening on model updates and updates the urls based on the model events - so with moving to Bookshelf, we need any easy way to add relations - the test env inserts test fixtures - it adds permissions and each permission get's roles attached - `models.Permission.add({roles: [...]})
2018-04-25 12:27:39 +02:00
it('without roles', function () {
return models.Permission.add({name: 'test', object_type: 'something', action_type: 'read something'})
.then(function (permission) {
permission.get('name').should.eql('test');
permission.get('object_type').should.eql('something');
permission.get('action_type').should.eql('read something');
});
});
it('with roles', function () {
return models.Permission.add({
name: 'test',
object_type: 'something',
action_type: 'write something',
roles: [testUtils.DataGenerator.forKnex.roles[1]]
}).then(function (permission) {
permission.get('name').should.eql('test');
permission.get('object_type').should.eql('something');
permission.get('action_type').should.eql('write something');
permission.related('roles').models[0].id.should.eql(testUtils.DataGenerator.forKnex.roles[1].id);
});
});
it('[error] validation', function () {
return models.Permission.add({})
.then(function () {
'Should fail'.should.be.true();
})
.catch(function (err) {
err.length.should.eql(3);
});
});
});
});
Reference in a new issue Copy permalink