Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity
ghost/ghost/admin/.eslintrc.js

31 lines
768 B
JavaScript
Raw Normal View History

💄🐷 sort-imports eslint rule (#712) no issue - adds `eslint-plugin-sort-imports-es6-autofix` dependency - implements ESLint's base `sort-imports` rule but has a distinction in that `import {foo} from 'bar';` is considered `multiple` rather than `single` - fixes ESLint's autofix behaviour so `eslint --fix` will actually fix the sort order - updates all unordered import rules by using `eslint --fix` With the increased number of `import` statements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify it.
2017-05-29 19:50:03 +01:00
/* eslint-env node */
switch from jshint/jscs to eslint no issue - drop `jshint`, `jscs`, and `ember-suave` dependencies - remove `grunt` related linting dependencies and tasks - remove linting build from Travis so that linting can be performed as part of the normal test suite (refs TryGhost/Ghost#7427) - add `ember-cli-eslint` and `eslint-plugin-ember-suave` dependencies - configure `eslint` to match our previous coding style - update config to run eslint tests as part of the normal test run - add `npm run lint` command to only run linter tests
2016-10-14 11:23:51 +01:00
module.exports = {
root: true,
Update ember core (#1389)
2019-12-13 15:15:06 +00:00
parser: 'babel-eslint',
parserOptions: {
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
Update dependency eslint to v7 (#1566) * Update dependency eslint to v7 * Fixed linting errors Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-05-17 22:53:37 +01:00
legacyDecorators: true
Update ember core (#1389)
2019-12-13 15:15:06 +00:00
}
},
💄🐷 sort-imports eslint rule (#712) no issue - adds `eslint-plugin-sort-imports-es6-autofix` dependency - implements ESLint's base `sort-imports` rule but has a distinction in that `import {foo} from 'bar';` is considered `multiple` rather than `single` - fixes ESLint's autofix behaviour so `eslint --fix` will actually fix the sort order - updates all unordered import rules by using `eslint --fix` With the increased number of `import` statements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify it.
2017-05-29 19:50:03 +01:00
plugins: [
Switch to eslint-plugin-ghost extending plugin:ghost/ember no issue - fix lint errors in lib/gh-koenig - fix ghost:base eslint errors - update ember plugin refs, remove ember-suave plugin refs - remove old jshint refs - add `lint:js` script - switch to `eslint-plugin-ghost` extending `plugin:ghost/ember`
2018-01-05 15:38:23 +00:00
'ghost'
],
extends: [
'plugin:ghost/ember'
💄🐷 sort-imports eslint rule (#712) no issue - adds `eslint-plugin-sort-imports-es6-autofix` dependency - implements ESLint's base `sort-imports` rule but has a distinction in that `import {foo} from 'bar';` is considered `multiple` rather than `single` - fixes ESLint's autofix behaviour so `eslint --fix` will actually fix the sort order - updates all unordered import rules by using `eslint --fix` With the increased number of `import` statements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify it.
2017-05-29 19:50:03 +01:00
],
switch from jshint/jscs to eslint no issue - drop `jshint`, `jscs`, and `ember-suave` dependencies - remove `grunt` related linting dependencies and tasks - remove linting build from Travis so that linting can be performed as part of the normal test suite (refs TryGhost/Ghost#7427) - add `ember-cli-eslint` and `eslint-plugin-ember-suave` dependencies - configure `eslint` to match our previous coding style - update config to run eslint tests as part of the normal test run - add `npm run lint` command to only run linter tests
2016-10-14 11:23:51 +01:00
rules: {
Updated members routes/controllers with Octane idioms no issue - ran [`ember-native-class-codemod`](https://github.com/ember-codemods/ember-native-class-codemod) on members-related files - updated files to remove need for `@classic` decorator where possible - switched to tracked properties - removed usage of `this.get/set/toggleProperty` etc - swapped usage of `{{action 'foo'}}` for `{{this.foo}}`
2020-05-20 14:55:41 +01:00
// octane 🏎
'ghost/ember/classic-decorator-hooks': 'error',
'ghost/ember/classic-decorator-no-classic-methods': 'error',
Switch to eslint-plugin-ghost extending plugin:ghost/ember no issue - fix lint errors in lib/gh-koenig - fix ghost:base eslint errors - update ember plugin refs, remove ember-suave plugin refs - remove old jshint refs - add `lint:js` script - switch to `eslint-plugin-ghost` extending `plugin:ghost/ember`
2018-01-05 15:38:23 +00:00
// disable linting of `this.get` until there's a reliable autofix
Upgraded `eslint-plugin-ghost` and fixed new linter errors no issue - update imports for `@ember-data` package (https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md) - use `computed.reads` where applicable (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-computed-macros.md) - fix usage of `scheduleOnce` so that functions are only scheduled once (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-incorrect-calls-with-inline-anonymous-functions.md)
2020-01-16 17:01:12 +00:00
'ghost/ember/use-ember-get-and-set': 'off',
// disable linting of mixins until we migrate away
Update dependency eslint-plugin-ghost to v1.4.0 no issue - applies fixes for new/updated rules - disables `ember/no-mixins` rule as we're not able to migrate away yet
2020-05-06 18:06:42 +01:00
'ghost/ember/no-mixins': 'off',
Upgraded `eslint-plugin-ghost` and fixed new linter errors no issue - update imports for `@ember-data` package (https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md) - use `computed.reads` where applicable (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-computed-macros.md) - fix usage of `scheduleOnce` so that functions are only scheduled once (https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-incorrect-calls-with-inline-anonymous-functions.md)
2020-01-16 17:01:12 +00:00
'ghost/ember/no-new-mixins': 'off'
switch from jshint/jscs to eslint no issue - drop `jshint`, `jscs`, and `ember-suave` dependencies - remove `grunt` related linting dependencies and tasks - remove linting build from Travis so that linting can be performed as part of the normal test suite (refs TryGhost/Ghost#7427) - add `ember-cli-eslint` and `eslint-plugin-ember-suave` dependencies - configure `eslint` to match our previous coding style - update config to run eslint tests as part of the normal test run - add `npm run lint` command to only run linter tests
2016-10-14 11:23:51 +01:00
}
};
Reference in a new issue Copy permalink