Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity
ghost/.eslintrc.json

21 lines
540 B
JSON
Raw Normal View History

Switch to Eslint (#9197) refs #9178 * Add eslint deps, remove old lint deps * Add eslint config, remove old lint configs * Config for server and tests are different * Tweaked rules to suit us * Fix linting in codebase - lots of indent changes. * Fix a real broken test
2017-11-01 13:44:54 +00:00
{
"env": {
"es6": true,
"node": true
},
Switched to eslint-plugin-ghost (#9835) refs #9834 - @TODO: the test env eslint needs to use the plugin, not part of this PR
2018-09-18 00:19:30 +05:30
"plugins": [
"ghost"
],
"extends": [
"plugin:ghost/node"
Updated var declarations to const/let and no lists - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
2020-04-29 16:44:27 +01:00
],
"rules": {
Added custom no-cross-requires eslint rule [soft] refs: https://github.com/TryGhost/eslint-plugin-ghost/commit/7e787ef80745e6627f7fcd3cf1a941263c521023 - bumps eslint-plugin-ghost to 2.1.0 which adds the code for a new custom rule - adds configuration to our eslint file to enable the rule in a very soft mode for now - this rule is intended to enforce not tightly coupling the server and frontend - the intention is to make it stricter over time as the number of cross requires reduces - enabling this rule temporarily and running lint is a nice way to grok just how tightly coupled things are at the moment
2021-04-26 15:06:57 +01:00
// @TODO: remove this rule once it's turned into "error" in the base plugin
Enabled error for "no-shadow" eslint rule refs 635580f291bd826c9119049ad968cb7702477ba7 - Changed `no-shadow` eslint rule from `warn` to `error` so we don't re-introduce shadowed variables in the future. Should be removed once this change is introduced in a base plugin - Referenced commit is a chain of commits which fixed the warning which this rule was producing previously
2020-10-27 11:27:37 +13:00
"no-shadow": "error",
Updated var declarations to const/let and no lists - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
2020-04-29 16:44:27 +01:00
"no-var": "error",
Added custom no-cross-requires eslint rule [soft] refs: https://github.com/TryGhost/eslint-plugin-ghost/commit/7e787ef80745e6627f7fcd3cf1a941263c521023 - bumps eslint-plugin-ghost to 2.1.0 which adds the code for a new custom rule - adds configuration to our eslint file to enable the rule in a very soft mode for now - this rule is intended to enforce not tightly coupling the server and frontend - the intention is to make it stricter over time as the number of cross requires reduces - enabling this rule temporarily and running lint is a nice way to grok just how tightly coupled things are at the moment
2021-04-26 15:06:57 +01:00
"one-var": [2, "never"],
// @TODO: enable this for all components once it gets a bit quieter
"ghost/ghost-custom/no-cross-requires": ["warn", {"shared": true, "server": false, "frontend": false}]
Updated var declarations to const/let and no lists - All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
2020-04-29 16:44:27 +01:00
}
Switch to Eslint (#9197) refs #9178 * Add eslint deps, remove old lint deps * Add eslint config, remove old lint configs * Config for server and tests are different * Tweaked rules to suit us * Fix linting in codebase - lots of indent changes. * Fix a real broken test
2017-11-01 13:44:54 +00:00
}
Reference in a new issue Copy permalink