Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity
ghost/core/client/app/templates/components/gh-modal-dialog.hbs

24 lines
1.2 KiB
Handlebars
Raw Normal View History

Refactor component styles Continues on from #4401 - Reformats the Sass to match our new style (property order, comments, & white space) - Changes the modal container to a class from an ID (and adjust tests)
2014-11-13 06:27:45 -05:00
<div class="modal-container js-modal-container" {{action "closeModal"}}>
Ember 1.11.1 - remove `bind-attr` all over the place
2015-04-01 11:01:38 -05:00
<article class="{{klass}} js-modal">
Use an explicit action name in action helper No Issue - Clicking on the body of a modal dialog causes an unhandled exception in the console. Add an explicit action name to the helper.
2014-12-25 21:26:55 -05:00
<section class="modal-content" {{action "noBubble" bubbles=false preventDefault=false}}>
Creates Ember Modal infastructure resolves #2416 This is a pretty large commit but what it's adding are pretty fundamental to the admin app. - Creates top level actions on the ApplicationRoute for opening and closing modals. This allows sending the 'openModal' action from any template to open a modal. - Every modal template lives in 'templates/modals/{{modalName}}' - Each modal can have a backing controller of the same name that can provide additional control for that modal. Those controllers reside in 'controllers/modals/{{modalName}}' - Created the ModalDialog component which is where all the logic for the component resides. It's not at 100% parity with the existing Ghost modal system but it has the foundation for further fleshing out. It currently accepts parameters for styling how the modal should appear, which previously was defined in JS files in the Backbone admin. - This creates the 'delete all posts', 'delete this post', 'markdown', and 'upload' modal. Some are in more stages of completion than others, but I wanted to just get the foundation in place as fast as possible. - This also creates the UploadModal component which is a subclass of the ModalDialog component. The reason for this subclassing is that the UploadModal component directly accesses the DOM and when that occurs in Ember it should remain in a component definition. It's ready for extending to reach parity. Note: depending on needs the base ModalDialog class may need to be modified.
2014-03-30 23:07:05 -05:00
{{#if title}}<header class="modal-header"><h1>{{title}}</h1></header>{{/if}}
First pass - strip mixins
2015-05-13 04:23:29 -05:00
{{#if showClose}}<a class="close icon-x" href="" title="Close" {{action "closeModal"}}><span class="hidden">Close</span></a>{{/if}}
Creates Ember Modal infastructure resolves #2416 This is a pretty large commit but what it's adding are pretty fundamental to the admin app. - Creates top level actions on the ApplicationRoute for opening and closing modals. This allows sending the 'openModal' action from any template to open a modal. - Every modal template lives in 'templates/modals/{{modalName}}' - Each modal can have a backing controller of the same name that can provide additional control for that modal. Those controllers reside in 'controllers/modals/{{modalName}}' - Created the ModalDialog component which is where all the logic for the component resides. It's not at 100% parity with the existing Ghost modal system but it has the foundation for further fleshing out. It currently accepts parameters for styling how the modal should appear, which previously was defined in JS files in the Backbone admin. - This creates the 'delete all posts', 'delete this post', 'markdown', and 'upload' modal. Some are in more stages of completion than others, but I wanted to just get the foundation in place as fast as possible. - This also creates the UploadModal component which is a subclass of the ModalDialog component. The reason for this subclassing is that the UploadModal component directly accesses the DOM and when that occurs in Ember it should remain in a component definition. It's ready for extending to reach parity. Note: depending on needs the base ModalDialog class may need to be modified.
2014-03-30 23:07:05 -05:00
<section class="modal-body">
{{yield}}
</section>
{{#if confirm}}
<footer class="modal-footer">
Ember 1.11.1 - remove `bind-attr` all over the place
2015-04-01 11:01:38 -05:00
<button type="button" class="{{rejectButtonClass}} js-button-reject" {{action "confirm" "reject"}}>
Creates Ember Modal infastructure resolves #2416 This is a pretty large commit but what it's adding are pretty fundamental to the admin app. - Creates top level actions on the ApplicationRoute for opening and closing modals. This allows sending the 'openModal' action from any template to open a modal. - Every modal template lives in 'templates/modals/{{modalName}}' - Each modal can have a backing controller of the same name that can provide additional control for that modal. Those controllers reside in 'controllers/modals/{{modalName}}' - Created the ModalDialog component which is where all the logic for the component resides. It's not at 100% parity with the existing Ghost modal system but it has the foundation for further fleshing out. It currently accepts parameters for styling how the modal should appear, which previously was defined in JS files in the Backbone admin. - This creates the 'delete all posts', 'delete this post', 'markdown', and 'upload' modal. Some are in more stages of completion than others, but I wanted to just get the foundation in place as fast as possible. - This also creates the UploadModal component which is a subclass of the ModalDialog component. The reason for this subclassing is that the UploadModal component directly accesses the DOM and when that occurs in Ember it should remain in a component definition. It's ready for extending to reach parity. Note: depending on needs the base ModalDialog class may need to be modified.
2014-03-30 23:07:05 -05:00
{{confirm.reject.text}}
Use CSS animations for modals No issue - Changes Modals to use CSS-based animations - All modals have an animation, so the option is removed from the handlebars helper - Removes `animation` from the handlebars helper, as all had one anyway - Removed the `centered` style - All modals should be left-aligned - Buttons now default to being on the left - Cleans up some styles (modal body top spacing) which #4632 helped clean up
2014-12-14 16:29:11 -05:00
</button><!--
Required to strip the white-space between buttons
Ember 1.11.1 - remove `bind-attr` all over the place
2015-04-01 11:01:38 -05:00
--><button type="button" class="{{acceptButtonClass}} js-button-accept" {{action "confirm" "accept"}}>
Swap button-order on modal dialogs Issue #4583 - Delete button should be on the right, cancel on the left, for all modal dialogs.
2014-12-10 10:02:27 -05:00
{{confirm.accept.text}}
</button>
Creates Ember Modal infastructure resolves #2416 This is a pretty large commit but what it's adding are pretty fundamental to the admin app. - Creates top level actions on the ApplicationRoute for opening and closing modals. This allows sending the 'openModal' action from any template to open a modal. - Every modal template lives in 'templates/modals/{{modalName}}' - Each modal can have a backing controller of the same name that can provide additional control for that modal. Those controllers reside in 'controllers/modals/{{modalName}}' - Created the ModalDialog component which is where all the logic for the component resides. It's not at 100% parity with the existing Ghost modal system but it has the foundation for further fleshing out. It currently accepts parameters for styling how the modal should appear, which previously was defined in JS files in the Backbone admin. - This creates the 'delete all posts', 'delete this post', 'markdown', and 'upload' modal. Some are in more stages of completion than others, but I wanted to just get the foundation in place as fast as possible. - This also creates the UploadModal component which is a subclass of the ModalDialog component. The reason for this subclassing is that the UploadModal component directly accesses the DOM and when that occurs in Ember it should remain in a component definition. It's ready for extending to reach parity. Note: depending on needs the base ModalDialog class may need to be modified.
2014-03-30 23:07:05 -05:00
</footer>
{{/if}}
</section>
</article>
</div>
Ember 1.11.1 - remove `bind-attr` all over the place
2015-04-01 11:01:38 -05:00
<div class="modal-background js-modal-background"></div>
Reference in a new issue Copy permalink