0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 07:43:18 -05:00
forgejo/models/migrations/v1_16
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
main_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v189.go
v189_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v190.go
v191.go
v192.go
v193.go
v193_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v194.go
v195.go
v195_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v196.go
v197.go
v198.go
v199.go
v200.go
v201.go
v202.go
v203.go
v204.go
v205.go
v206.go
v207.go
v208.go
v209.go
v210.go Fix some bug on migrations (#30647) 2024-04-28 15:39:01 +02:00
v210_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00