Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 08:06:49 -05:00
Code Issues Activity
forgejo/modules
History
flozzone a39287cd4e
Send mail to issue/pr assignee/reviewer also when OnMention is set (#18707) 
I want to address #17892, where emails notifications are not sent to assignees (issue and PR) and reviewers (PR) when they have the email setting Only email on mention enabled.

From the user experience perspective, when a user gets a issue/PR assigned or a PR review request, he/she would expect to be implicitly mentioned since the assignment or request is personal and targeting a single person only. Thus I see #17892 as a bug. Could we therefore mark this ticket as such?

The changed code just explicitly checks for the EmailNotificationsOnMention setting beside the existing EmailNotificationsEnabled check. Too rude?

@lunny mentioned a mock mail server for tests, is there something ready. How could I make use of it?

#12774 (comment)

Fix #17892
2022-02-12 07:17:34 +00:00
..
activitypub format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
analyze Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
appstate format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
auth format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
avatar format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
base format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
cache format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
charset format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
context Display template path of current page in dev mode (#18717) 2022-02-12 01:08:22 +08:00
convert API: Return primary language and repository language stats API URL (#18396) 2022-01-25 08:33:40 +02:00
csv format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
doctor Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
emoji format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
eventsource Simplify parameter types (#18006) 2021-12-20 04:41:31 +00:00
generate Use base32 for 2FA scratch token (#18384) 2022-01-26 12:10:10 +08:00
git Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
gitgraph Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
graceful format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
hcaptcha
highlight format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
hostmatcher Simplify parameter types (#18006) 2021-12-20 04:41:31 +00:00
httpcache format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
httplib refactor httplib (#18338) 2022-01-19 19:31:39 -05:00
indexer Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
json Make gitea, gitea-vet future-proof (#18361) 2022-01-22 21:59:34 +00:00
lfs format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
log format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
markup Prevent NPE on partial match of compare URL and allow short SHA1 compare URLs (#18472) 2022-01-31 01:48:47 +02:00
metrics format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
migration add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
nosql format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
notification Send mail to issue/pr assignee/reviewer also when OnMention is set (#18707) 2022-02-12 07:17:34 +00:00
options format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
password
pprof refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
private Validate migration files (#18203) 2022-01-26 10:45:51 +01:00
process format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
proxy Return nil proxy function if proxy not enabled (#16742) 2021-08-19 16:41:20 -04:00
public Fix mime-type detection for HTTP server (#18370) 2022-01-23 20:19:49 +08:00
queue Add number in queue status to monitor page (#18712) 2022-02-12 13:31:26 +08:00
recaptcha refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
references format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
repository Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
secret Use CryptoRandomBytes instead of CryptoRandomString (#18439) 2022-02-04 18:03:15 +01:00
session format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
setting Update SSH Server crypto settings (#18697) 2022-02-10 17:04:16 +01:00
ssh format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
storage format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
structs Add apply-patch, basic revert and cherry-pick functionality (#17902) 2022-02-09 20:28:55 +00:00
svg refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
sync
templates format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
test format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
timeutil format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
translation Refactor i18n, use Locale to provide i18n/translation related functions (#18648) 2022-02-08 11:02:30 +08:00
typesniffer format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
updatechecker format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
upload Simplify parameter types (#18006) 2021-12-20 04:41:31 +00:00
uri Prevent NPE if gitea uploader fails to open url (#18080) 2021-12-23 16:27:33 +00:00
user
util Fix non-ASCII search on database (#18437) 2022-02-01 20:59:25 +08:00
validation format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
web Fix route wrap (#18360) 2022-01-22 15:05:22 +00:00