mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-23 07:43:18 -05:00
ef89e75d0e
* add request review feature in pull request add a way to notify specific reviewers to review like github , by add or delet a special type review . The acton is is similar to Assign , so many code reuse the function and items of Assignee, but the meaning and result is different. The Permission style is is similar to github, that only writer can add a review request from Reviewers, but the poster can recall and remove a review request after a reviwer has revied even if he don't have Write Premission. only manager , the poster and reviewer of a request review can remove it. The reviewers can be requested to review contain all readers for private repo , for public, contain all writers and watchers. The offical Review Request will block merge if Reject can block it. an other change: add ui otify for Assignees. Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv> Signed-off-by: a1012112796 <1012112796@qq.com> * new change * add placeholder string * do some changes follow #10238 to add review requests num on lists also change icon for review requests to eye Co-authored-by: Lauris BH <lauris@nix.lv>
73 lines
1.9 KiB
Go
73 lines
1.9 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package issue
|
|
|
|
import (
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/notification"
|
|
)
|
|
|
|
// DeleteNotPassedAssignee deletes all assignees who aren't passed via the "assignees" array
|
|
func DeleteNotPassedAssignee(issue *models.Issue, doer *models.User, assignees []*models.User) (err error) {
|
|
var found bool
|
|
|
|
for _, assignee := range issue.Assignees {
|
|
|
|
found = false
|
|
for _, alreadyAssignee := range assignees {
|
|
if assignee.ID == alreadyAssignee.ID {
|
|
found = true
|
|
break
|
|
}
|
|
}
|
|
|
|
if !found {
|
|
// This function also does comments and hooks, which is why we call it seperatly instead of directly removing the assignees here
|
|
if _, _, err := ToggleAssignee(issue, doer, assignee.ID); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ToggleAssignee changes a user between assigned and not assigned for this issue, and make issue comment for it.
|
|
func ToggleAssignee(issue *models.Issue, doer *models.User, assigneeID int64) (removed bool, comment *models.Comment, err error) {
|
|
removed, comment, err = issue.ToggleAssignee(doer, assigneeID)
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
assignee, err1 := models.GetUserByID(assigneeID)
|
|
if err1 != nil {
|
|
err = err1
|
|
return
|
|
}
|
|
|
|
notification.NotifyIssueChangeAssignee(doer, issue, assignee, removed, comment)
|
|
|
|
return
|
|
}
|
|
|
|
// ReviewRequest add or remove a review for this PR, and make comment for it.
|
|
func ReviewRequest(issue *models.Issue, doer *models.User, reviewer *models.User, isAdd bool) (err error) {
|
|
var comment *models.Comment
|
|
if isAdd {
|
|
comment, err = models.AddRewiewRequest(issue, reviewer, doer)
|
|
} else {
|
|
comment, err = models.RemoveRewiewRequest(issue, reviewer, doer)
|
|
}
|
|
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
if comment != nil {
|
|
notification.NotifyPullRewiewRequest(doer, issue, reviewer, isAdd, comment)
|
|
}
|
|
|
|
return nil
|
|
}
|