0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-03-13 07:02:01 -05:00
forgejo/services/context
Matthias Riße 5a2f2229d2 fix: return 404 for empty repositories (#7003)
- Some endpoints (`/api/v1/repos/*/*/raw`, `/api/v1/repos/*/*/media`, ...;
anything that uses both `context.ReferencesGitRepo()` and
`context.RepoRefForAPI` really) returned a 500 when the repository was
completely empty. This resulted in some confusion in
https://github.com/datalad/datalad-usage-dashboard/issues/47 because the
same request for a non-existent file in a repository could sometimes
generate a 404 and sometimes a 500, depending on if the git repository
is initialized at all or not.

Returning a 404 is more appropriate here, since this isn't an
unexpected internal error, but just another way of not finding the
requested data.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7003
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Matthias Riße <m.risse@fz-juelich.de>
Co-committed-by: Matthias Riße <m.risse@fz-juelich.de>
2025-02-20 21:50:46 +00:00
..
upload
access_log.go
api.go fix: return 404 for empty repositories (#7003) 2025-02-20 21:50:46 +00:00
api_org.go
api_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
base.go
base_test.go
captcha.go [CHORE] Move cache library 2024-08-27 21:28:56 +02:00
context.go [PORT] Refactor DateUtils and merge TimeSince (gitea#32409) 2024-11-10 22:23:27 +01:00
context_cookie.go fix: extend forgejo_auth_token table 2024-11-15 10:59:36 +01:00
context_model.go
context_request.go
context_response.go
context_template.go
context_test.go
csrf.go Update services/context/csrf.go 2024-11-28 10:12:46 +00:00
org.go Calculate PublicOnly for org membership only once (#32234) 2024-11-17 21:57:34 +01:00
package.go
pagination.go
permission.go
private.go
quota.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
repo.go fix: always set stripped slashes on http request 2025-02-10 12:55:11 +01:00
repository.go
response.go
user.go
utils.go
xsrf.go
xsrf_test.go