0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 07:43:18 -05:00
forgejo/web_src/css
wxiaoguang 027014d7de
Fix webauthn regression and improve code (#25113)
Follow:

* #22697

There are some bugs in #22697:

* https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966
* the webauthn failure message is never shown and causes console error
* The `document.getElementById('register-button')` and
`document.getElementById('login-button')` is wrong
    * there is no such element in code
    * it causes JS error when a browser doesn't provide webauthn
    * the end user can't see the real error message

These bugs are fixed in this PR.

Other changes:

* Use simple HTML/CSS layouts, no need to use too many `gt-` patches
* Make the webauthn page have correct "page-content" layout
* The "data-webauthn-error-msg" elements are only used to provide locale
texts, so move them into a single "gt-hidden", then no need to repeat a
lot of "gt-hidden" in code
* The `{{.CsrfTokenHtml}}`  is a no-op because there is no form
* Many `hideElem('#webauthn-error')` in code is no-op because the
`webauthn-error` already has "gt-hidden" by default
* Make the tests for "URLEncodedBase64" really test with concrete cases.


Screenshots:

* Error message when webauthn fails (before, there is no error message):

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b)

</details>

* Error message when webauthn is unavailable 

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2)

</details>
2023-06-07 19:20:18 +08:00
..
chroma Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables (#24827) 2023-05-21 23:37:32 +00:00
codemirror
editor Rework button coloring, add focus and active colors (#24507) 2023-05-29 12:45:22 +00:00
features Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables (#24827) 2023-05-21 23:37:32 +00:00
markup Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables (#24827) 2023-05-21 23:37:32 +00:00
modules Add button on diff header to copy file name, misc diff header tweaks (#24986) 2023-06-01 10:47:28 +00:00
repo Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables (#24827) 2023-05-21 23:37:32 +00:00
shared Add details summary for vertical menus in settings to allow toggling (#25098) 2023-06-07 10:49:48 +08:00
standalone Add dark mode to API Docs (#24971) 2023-05-28 21:37:34 +00:00
themes Add show timestamp/seconds and fullscreen options to action page (#24876) 2023-05-30 20:38:55 +00:00
actions.css Reorganize CSS files (#24739) 2023-05-16 00:13:30 -04:00
admin.css Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables (#24827) 2023-05-21 23:37:32 +00:00
base.css Add details summary for vertical menus in settings to allow toggling (#25098) 2023-06-07 10:49:48 +08:00
dashboard.css Fix incorrect issuel filter menu style (#25018) 2023-05-31 12:44:28 +02:00
explore.css Consolidate the two review boxes into one (#24738) 2023-05-29 12:44:03 +02:00
font_i18n.css Fix @font-face overrides (#24855) 2023-05-24 01:48:51 +00:00
form.css Fix webauthn regression and improve code (#25113) 2023-06-07 19:20:18 +08:00
helpers.css Redesign Scoped Access Tokens (#24767) 2023-06-04 20:57:16 +02:00
home.css Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393) 2023-04-29 07:35:59 -04:00
index.css Add details summary for vertical menus in settings to allow toggling (#25098) 2023-06-07 10:49:48 +08:00
install.css Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables (#24827) 2023-05-21 23:37:32 +00:00
org.css Reorganize CSS files (#24739) 2023-05-16 00:13:30 -04:00
repo.css Clean up WebAuthn javascript code and remove JQuery code (#22697) 2023-06-06 13:29:37 +08:00
review.css Improve accessibility when (re-)viewing files (#24817) 2023-05-21 20:47:41 +00:00
user.css Rework notifications list (#24812) 2023-05-25 02:31:26 +00:00