0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-28 02:14:06 -05:00
forgejo/modules/context
Lunny Xiao ca67c5a8a7
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 13:53:28 +08:00
..
access_log.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
api.go refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
api_org.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
api_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
captcha.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
context.go refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
csrf.go Update gitea-vet to check FSFE REUSE (#22004) 2022-12-02 22:14:57 +08:00
form.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
package.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
pagination.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
permission.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
private.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Use complete SHA to create and query commit status (#22244) 2022-12-27 21:12:49 +08:00
response.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
utils.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
xsrf.go Update gitea-vet to check FSFE REUSE (#22004) 2022-12-02 22:14:57 +08:00
xsrf_test.go Update gitea-vet to check FSFE REUSE (#22004) 2022-12-02 22:14:57 +08:00