0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-02-02 03:39:25 -05:00
Beyond coding. We forge.
Find a file
Gergely Nagy e35d2af2e5
Rate limit pre-activation email change separately
Changing the email address before any email address is activated should
be subject to a different rate limit than the normal activation email
resending. If there's only one rate limit for both, then if a newly
signed up quickly discovers they gave a wrong email address, they'd have
to wait three minutes to change it.

With the two separate limits, they don't - but they'll have to wait
three minutes before they can change the email address again.

The downside of this setup is that a malicious actor can alternate
between resending and changing the email address (to something like
`user+$idx@domain`, delivered to the same inbox) to effectively halving
the rate limit. I do not think there's a better solution, and this feels
like such a small attack surface that I'd deem it acceptable.

The way the code works after this change is that `ActivatePost` will now
check the `MailChangeLimit_user` key rather than `MailResendLimit_user`,
and if we're within the limit, it will set `MailChangedJustNow_user`. The
`Activate` method - which sends the activation email, whether it is a
normal resend, or one following an email change - will check
`MailChangedJustNow_user`, and if it is set, it will check the rate
limit against `MailChangedLimit_user`, otherwise against
`MailResendLimit_user`, and then will delete the
`MailChangedJustNow_user` key from the cache.

Fixes #2040.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2023-12-27 12:09:16 +01:00
.devcontainer
.forgejo
.gitea
assets [GITEA] Use maintained gziphandler 2023-12-25 13:41:48 +01:00
build
cmd
contrib [GITEA] fix VSCode settings 2023-12-25 13:41:49 +01:00
custom/conf [GITEA] Revert "Deprecate query string auth tokens (#28390)" 2023-12-25 13:41:50 +01:00
docker
docs [GITEA] notifies admins on new user registration 2023-12-25 13:33:42 +01:00
models [GITEA] Allow changing the email address before activation 2023-12-25 13:41:50 +01:00
modules [ACTIONS] on.schedule: create a new payload 2023-12-25 13:45:36 +01:00
options [GITEA] Allow changing the email address before activation 2023-12-25 13:41:50 +01:00
public
releases/images
routers Rate limit pre-activation email change separately 2023-12-27 12:09:16 +01:00
services [ACTIONS] on.schedule: do not cancel jobs 2023-12-25 13:45:36 +01:00
snap
templates [GITEA] Revert "Deprecate query string auth tokens (#28390)" 2023-12-25 13:41:50 +01:00
tests Rate limit pre-activation email change separately 2023-12-27 12:09:16 +01:00
web_src [GITEA] Use vertical tabs on issue filters 2023-12-25 13:30:06 +01:00
.air.toml
.changelog.yml
.deadcode-out [GITEA] Enable mocked HTTP responses for GitLab migration test 2023-12-25 13:41:49 +01:00
.dockerignore
.editorconfig
.eslintrc.yaml
.gitattributes
.gitignore
.gitpod.yml
.golangci.yml
.ignore
.markdownlint.yaml
.npmrc
.spectral.yaml
.stylelintrc.yaml
.yamllint.yaml
BSDmakefile
build.go
CHANGELOG.md
CODEOWNERS
CONTRIBUTING.md
DCO
Dockerfile
Dockerfile.rootless
go.mod [GITEA] Use existing error functionality 2023-12-25 13:41:48 +01:00
go.sum [GITEA] Use maintained gziphandler 2023-12-25 13:41:48 +01:00
LICENSE
main.go
MAINTAINERS
Makefile [SEMVER] 7.0.0+0-gitea-1.22.0 2023-12-25 11:02:14 +01:00
package-lock.json
package.json
playwright.config.js
poetry.lock
poetry.toml
pyproject.toml
README.md
RELEASE-NOTES.md
vitest.config.js
webpack.config.js

Welcome to Forgejo

Hi there! Tired of big platforms playing monopoly? Providing Git hosting for your project, friends, company or community? Forgejo (/for'd͡ʒe.jo/ inspired by forĝejo the Esperanto word for forge) has you covered with its intuitive interface, light and easy hosting and a lot of builtin functionality.

Forgejo was created in 2022 because we think that the project should be owned by an independent community. If you second that, then Forgejo is for you! Our promise: Independent Free/Libre Software forever!

What does Forgejo offer?

If you like any of the following, Forgejo is literally meant for you:

  • Lightweight: Forgejo can easily be hosted on nearly every machine. Running on a Raspberry? Small cloud instance? No problem!
  • Project management: Besides Git hosting, Forgejo offers issues, pull requests, wikis, kanban boards and much more to coordinate with your team.
  • Publishing: Have something to share? Use releases to host your software for download, or use the package registry to publish it for docker, npm and many other package managers.
  • Customizable: Want to change your look? Change some settings? There are many config switches to make Forgejo work exactly like you want.
  • Powerful: Organizations & team permissions, CI integration, Code Search, LDAP, OAuth and much more. If you have advanced needs, Forgejo has you covered.
  • Privacy: From update checker to default settings: Forgejo is built to be privacy first for you and your crew.
  • Federation: (WIP) We are actively working to connect software forges with each other through ActivityPub, and create a collaborative network of personal instances.

Learn more

Dive into the documentation, subscribe to releases and blog post on our website, find us on the Fediverse or hop into our Matrix room if you have any questions or want to get involved.

Get involved

If you are interested in making Forgejo better, either by reporting a bug or by changing the governance, please take a look at the contribution guide.