0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-03-10 05:32:06 -05:00
forgejo/tests/integration
Gergely Nagy 9ba48419ba Teach activities.GetFeeds() how to avoid returning duplicates
Before explaining the fix itself, lets look at the `action` table, and
how it is populated. Data is only ever inserted into it via
`activities_model.NotifyWatchers`, which will:

- Insert a row for each activity with `UserID` set to the acting user's
  ID - this is the original activity, and is always inserted if anything
  is to be inserted at all.
- It will insert a copy of each activity with the `UserID` set to the
  repo's owner, if the owner is an Organization, and isn't the acting
  user.
- It will insert a copy of each activity for every watcher of the repo,
  as long as the watcher in question has read permission to the repo
  unit the activity is about.

This means that if a repository belongs to an organizations, for most
activities, it will have at least two rows in the table. For
repositories watched by people other than their owner, an additional row
for each watcher.

These are useful duplicates, because they record which activities are
relevant for a particular user. However, for cases where we wish to see
the activities that happen around a repository, without limiting the
results to a particular user, we're *not* interested in the duplicates
stored for the watchers and the org. We only need the originals.

And this is what this change does: it introduces an additional option to
`GetFeedsOptions`: `OnlyPerformedByActor`. When this option is set,
`activities.GetFeeds()` will only return the original activities, where
the user id and the acting user id are the same. As these are *always*
inserted, we're not missing out on any activities. We're just getting
rid of the duplicates. As this is an additional `AND` condition, it can
never introduce items that would not have been included in the result
set before, it can only reduce, not extend.

These duplicates were only affecting call sites where `RequestedRepo`
was set, but `RequestedUser` and `RequestedTeam` were not. Both of those
call sites were updated to set `OnlyPerformedByActor`. As a result,
repository RSS feeds, and the `/repos/{owner}/{repo}/activities/feeds`
API end points no longer return dupes, only the original activities.

Rather than hardcoding this behaviour into `GetFeeds()` itself, I chose
to implement it as an explicit option, for the sake of clarity.

Fixes Codeberg/Community#684, and addresses gitea#20986.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 9cb2aa989a)
2024-05-09 18:37:30 +00:00
..
fixtures
migration-test
schemas
actions_commit_status_test.go fix(actions): call automerge service on successful commit state 2024-04-15 16:51:22 +00:00
actions_route_test.go
actions_trigger_test.go Fix invalid link of the commit status when ref is tag (#29752) 2024-03-26 19:04:25 +01:00
admin_config_test.go
admin_user_test.go
api_actions_artifact_test.go
api_actions_artifact_v4_test.go
api_activitypub_person_test.go
api_admin_org_test.go
api_admin_test.go
api_block_test.go
api_branch_test.go
api_comment_attachment_test.go Catch and handle unallowed file type errors in issue attachment API (#30791) 2024-05-07 08:12:34 +01:00
api_comment_test.go
api_feed_plain_text_titles_test.go
api_feed_user_test.go
api_forgejo_root_test.go
api_forgejo_version_test.go
api_fork_test.go Allow admins to fork repos even when creation limits are exhausted (#3277) 2024-04-17 06:06:48 +00:00
api_gitignore_templates_test.go
api_gpg_keys_test.go
api_health_test.go Remove useless t.run 2024-04-06 08:44:23 +00:00
api_helper_for_declarative_test.go
api_httpsig_test.go
api_issue_attachment_test.go Catch and handle unallowed file type errors in issue attachment API (#30791) 2024-05-07 08:12:34 +01:00
api_issue_config_test.go
api_issue_label_test.go
api_issue_milestone_test.go
api_issue_pin_test.go
api_issue_reaction_test.go
api_issue_stopwatch_test.go
api_issue_subscription_test.go
api_issue_templates_test.go
api_issue_test.go Fix no edit history after editing issue's title and content (#30814) 2024-05-07 08:21:38 +01:00
api_issue_tracked_time_test.go
api_keys_test.go
api_label_templates_test.go
api_license_templates_test.go
api_nodeinfo_test.go
api_notification_test.go
api_oauth2_apps_test.go
api_org_avatar_test.go
api_org_test.go
api_packages_alpine_test.go
api_packages_cargo_test.go Run go generate and go vet on all packages (#30529) 2024-04-21 18:09:48 +02:00
api_packages_chef_test.go
api_packages_composer_test.go
api_packages_conan_test.go
api_packages_conda_test.go
api_packages_container_test.go
api_packages_cran_test.go
api_packages_debian_test.go
api_packages_generic_test.go Relax generic package filename restrictions (#30135) 2024-03-30 07:17:31 +01:00
api_packages_goproxy_test.go
api_packages_helm_test.go
api_packages_maven_test.go
api_packages_npm_test.go
api_packages_nuget_test.go feat: improve nuget nuspec api 2024-04-06 08:32:53 +00:00
api_packages_pub_test.go
api_packages_pypi_test.go Update tests/integration/api_packages_pypi_test.go 2024-04-12 22:23:58 +00:00
api_packages_rpm_test.go
api_packages_rubygems_test.go
api_packages_swift_test.go
api_packages_test.go
api_packages_vagrant_test.go
api_private_serv_test.go
api_pull_commits_test.go
api_pull_review_test.go
api_pull_test.go Fix no edit history after editing issue's title and content (#30814) 2024-05-07 08:21:38 +01:00
api_releases_test.go
api_repo_activities_test.go Teach activities.GetFeeds() how to avoid returning duplicates 2024-05-09 18:37:30 +00:00
api_repo_archive_test.go
api_repo_avatar_test.go
api_repo_branch_test.go
api_repo_collaborator_test.go
api_repo_edit_test.go
api_repo_file_create_test.go
api_repo_file_delete_test.go
api_repo_file_get_test.go
api_repo_file_helpers.go
api_repo_file_update_test.go
api_repo_files_change_test.go
api_repo_get_contents_list_test.go
api_repo_get_contents_test.go
api_repo_git_blobs_test.go
api_repo_git_commits_test.go
api_repo_git_hook_test.go
api_repo_git_notes_test.go
api_repo_git_ref_test.go
api_repo_git_tags_test.go
api_repo_git_trees_test.go
api_repo_hook_test.go
api_repo_languages_test.go
api_repo_lfs_locks_test.go
api_repo_lfs_migrate_test.go
api_repo_lfs_test.go
api_repo_raw_test.go
api_repo_secrets_test.go
api_repo_tags_test.go
api_repo_teams_test.go
api_repo_test.go Don't only list code-enabled repositories when using repository API (#30817) 2024-05-07 08:17:35 +01:00
api_repo_topic_test.go
api_settings_test.go
api_team_test.go
api_team_user_test.go
api_token_test.go
api_twofa_test.go
api_user_avatar_test.go
api_user_email_test.go
api_user_follow_test.go
api_user_heatmap_test.go
api_user_info_test.go
api_user_org_perm_test.go
api_user_orgs_test.go
api_user_search_test.go
api_user_secrets_test.go
api_user_star_test.go
api_user_watch_test.go
api_wiki_test.go
archived_labels_display_test.go Add integration test for (non-)archived label properties 2024-04-03 20:14:39 +00:00
attachment_test.go
auth_ldap_test.go
auth_token_test.go
avatar.png
benchmarks_test.go
block_test.go
branches_test.go
change_default_branch_test.go
cmd_admin_test.go test(cli): admin user change-password --must-change-password 2024-04-24 22:26:37 +00:00
cmd_forgejo_actions_test.go [TESTS] prevent overriding testlogger when calling mainApp 2024-04-01 16:36:04 +02:00
cmd_keys_test.go [TESTS] prevent overriding testlogger when calling mainApp 2024-04-01 16:36:04 +02:00
codeowner_test.go
compare_test.go [v7.0/forgejo] Fix "view file" button in diff compare view (#3077) 2024-04-06 13:24:55 +00:00
cors_test.go
create_no_session_test.go
csrf_test.go
db_collation_test.go
delete_user_test.go
doctor_packages_nuget_test.go feat: improve nuget nuspec api 2024-04-06 08:32:53 +00:00
download_test.go
dump_restore_test.go
easymde_test.go Add integration test for EasyMDE button 2024-04-19 13:49:21 +00:00
editor_test.go [BUG] Escape editor.add_tmpl translation 2024-04-16 16:23:25 +00:00
empty_repo_test.go
eventsource_test.go
explore_code_test.go [v7.0/forgejo] [BUG] Fix code search in explore reporting as git grep even with indexer enabled (#3204) 2024-04-14 14:21:31 +00:00
explore_repos_test.go
explore_user_test.go Remove unnecessary ".Link" usages (#29909) 2024-03-26 19:04:26 +01:00
forgejo_confirmation_repo_test.go
forgejo_git_test.go
git_clone_wiki_test.go
git_helper_for_declarative_test.go
git_push_test.go hooks: Harden when we accept push options that change repo settings 2024-04-20 05:58:39 +00:00
git_smart_http_test.go
git_test.go add missing defer 2024-04-16 10:28:48 +02:00
goget_test.go
gpg_git_test.go
html_helper.go
incoming_email_test.go fix(incoming): allow replies to comments 2024-04-22 22:43:16 +00:00
integration_test.go tests: Support creating a declarative repo without AutoInit 2024-05-01 13:32:39 +02:00
issue_test.go Add a test case for unsubscribing from an issue 2024-05-01 13:32:39 +02:00
lfs_getobject_test.go
lfs_local_endpoint_test.go
lfs_view_test.go [v7.0/forgejo] fix(ui): /settings/lfs/find 500 error (#3451) 2024-04-25 21:46:25 +00:00
linguist_test.go
links_test.go [REFACTOR] webhook move edit endpoints 2024-03-27 22:26:55 +01:00
markup_external_test.go Run go generate and go vet on all packages (#30529) 2024-04-21 18:09:48 +02:00
markup_test.go
migrate_test.go
mirror_pull_test.go
mirror_push_test.go
nonascii_branches_test.go
oauth_test.go
org_count_test.go
org_project_test.go
org_team_invite_test.go
org_test.go add label filters in org/{org_name}/issues 2024-04-04 17:37:56 +00:00
private-testing.key
privateactivity_test.go
proctected_branch_test.go [FEAT] Configure if protected branch rule should apply to admins 2024-04-01 19:31:43 +00:00
project_test.go
pull_compare_test.go
pull_create_test.go
pull_diff_test.go
pull_merge_test.go [TEST] webhook creation payload ref 2024-04-06 07:30:48 +00:00
pull_reopen_test.go
pull_request_task_test.go Do not update PRs based on events that happened before they existed 2024-04-12 10:41:19 +02:00
pull_review_test.go [TESTS] pull review deleted from gitea#29888 2024-04-03 08:13:14 +00:00
pull_status_test.go
pull_summary_test.go
pull_update_test.go Performance improvements for pull request list page (#29900) 2024-03-26 19:04:26 +01:00
pull_wip_convert_test.go
README.md
README_ZH.md
release_test.go Fix incorrect tailwind migration (#30007) 2024-03-26 19:04:27 +01:00
rename_branch_test.go [PORT] gitea#30430: Fix rename branch 500 when the target branch is deleted but exist in database 2024-04-15 15:52:24 +00:00
repo_activity_test.go Show repo activities even if only code unit active or git repo is empty but issue is active (#3455) 2024-04-28 13:50:45 +00:00
repo_archive_test.go Skip gzip for some well-known compressed file types (#30796) 2024-05-07 07:59:45 +01:00
repo_archive_text_test.go
repo_badges_test.go
repo_branch_test.go
repo_commits_search_test.go
repo_commits_test.go
repo_flags_test.go
repo_fork_test.go
repo_generate_test.go
repo_mergecommit_revert_test.go Run go generate and go vet on all packages (#30529) 2024-04-21 18:09:48 +02:00
repo_migrate_test.go
repo_pagination_test.go
repo_search_test.go [v7.0/forgejo] [BUG] Fix code search in explore reporting as git grep even with indexer enabled (#3204) 2024-04-14 14:21:31 +00:00
repo_settings_hook_test.go
repo_settings_test.go Fix the settings tab highlighting 2024-04-12 20:46:24 +00:00
repo_signed_tag_test.go An integration test for SSH signed tags 2024-04-01 13:42:11 +00:00
repo_starwatch_test.go
repo_tag_test.go
repo_test.go
repo_topic_test.go
repo_watch_test.go
repo_webhook_test.go webhook: add admin-hooks tests 2024-04-09 21:57:34 +00:00
repo_wiki_test.go
repofiles_change_test.go
session_test.go
setting_test.go
signin_test.go
signout_test.go
signup_test.go
size_translations_test.go [I18N] Allow custom repo size format 2024-04-02 18:04:32 +00:00
ssh_key_test.go
timetracking_test.go
user_avatar_test.go
user_count_test.go Show repo count in blocked users tab (#3601) 2024-05-02 17:10:06 +00:00
user_profile_test.go
user_test.go [v7.0/forgejo] Add optional pronoun field in user settings (#3076) 2024-04-06 13:23:43 +00:00
version_test.go
view_test.go [BUG] Disable 'View at this point in history' for wikis 2024-04-03 17:10:28 +00:00
webfinger_test.go fix: respond with JSON Resource Descriptor Content-Type per RFC7033 2024-04-02 09:41:57 +00:00
webhook_test.go Add tests for webhook release events 2024-04-16 18:28:54 +00:00
xss_test.go

Integration tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-sqlite
make test-pgsql
make test-mysql
make test-mssql

Make sure to perform a clean build before running tests:

make clean build

Run tests via local act_runner

Run all jobs

act_runner exec -W ./.github/workflows/pull-db-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest

Warning: This file defines many jobs, so it will be resource-intensive and therefor not recommended.

Run single job

act_runner exec -W ./.github/workflows/pull-db-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest -j <job_name>

You can list all job names via:

act_runner exec -W ./.github/workflows/pull-db-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest -l

Run sqlite integration tests

Start tests

make test-sqlite

Run MySQL integration tests

Setup a MySQL database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -p 3306:3306 --rm --name mysql mysql:latest #(just ctrl-c to stop db and clean the container)
docker run -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" --rm --name elasticsearch elasticsearch:7.6.0 #(in a second terminal, just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integration tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Run mssql integration tests

Setup a mssql database inside docker

docker run -e "ACCEPT_EULA=Y" -e "MSSQL_PID=Standard" -e "SA_PASSWORD=MwantsaSecurePassword1" -p 1433:1433 --rm --name mssql microsoft/mssql-server-linux:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql

Running individual tests

Example command to run GPG test:

For SQLite:

make test-sqlite#GPG

For other databases(replace mssql to mysql, or pgsql):

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG

Setting timeouts for declaring long-tests and long-flushes

We appreciate that some testing machines may not be very powerful and the default timeouts for declaring a slow test or a slow clean-up flush may not be appropriate.

You can either:

  • Within the test ini file set the following section:
[integration-tests]
SLOW_TEST = 10s ; 10s is the default value
SLOW_FLUSH = 5S ; 5s is the default value
  • Set the following environment variables:
GITEA_SLOW_TEST_TIME="10s" GITEA_SLOW_FLUSH_TIME="5s" make test-sqlite