Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 07:43:18 -05:00
Code Issues Activity
forgejo/web_src/js/features
History
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337) 
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
admin Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
comp Scoped labels: set aria-disabled on muted Exclusive option for a11y (#23306) 2023-03-05 21:25:25 +08:00
aria.js Fix incorrect display for comment context menu (#23343) 2023-03-08 11:26:37 +08:00
aria.md Improve frontend guidelines (#23007) 2023-02-21 14:13:37 +08:00
captcha.js Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
citation.js Fix switched citation format (#23250) 2023-03-02 13:08:02 -06:00
clipboard.js Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
codeeditor.js
colorpicker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
common-global.js Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
common-issue.js Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
common-organization.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
contextpopup.js Change interactiveBorder to fix popup preview (#23169) 2023-03-05 23:40:50 +08:00
copycontent.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
dropzone.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
emoji.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
eventsource.sharedworker.js
file-fold.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
formatting.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
heatmap.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
imagediff.js Fix various ImageDiff/SVG bugs (#23312) 2023-03-07 20:11:24 +08:00
install.js Fix various bugs for "install" page (#23194) 2023-03-04 10:12:02 +08:00
notification.js Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
org-team.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
pull-view-file.js
repo-branch.js
repo-code.js Fix links for the menus in the view file page (#22795) 2023-02-08 00:08:44 +08:00
repo-code.test.js
repo-commit.js Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
repo-common.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-diff-filetree.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-diff.js Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 2023-03-04 02:13:37 -05:00
repo-editor.js Support paste treepath when creating a new file or updating the file name (#23209) 2023-03-03 17:28:20 -05:00
repo-findfile.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-findfile.test.js Escape path for the file list (#22741) 2023-02-04 10:30:55 +00:00
repo-graph.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-home.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-issue-content.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-issue-pr-form.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-issue.js Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
repo-legacy.js Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
repo-migrate.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-migration.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-projects.js Sync the class change of Edit Column Button to JS code (#23400) 2023-03-12 19:09:20 +08:00
repo-release.js Hide target selector if tag exists when creating new release (#23171) 2023-03-10 10:42:38 -06:00
repo-settings.js
repo-template.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-unicode-escape.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-wiki.js
serviceworker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
sshkey-helper.js
stopwatch.js Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
tablesort.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
tribute.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
user-auth-webauthn.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
user-auth.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
user-settings.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00