Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-27 09:54:15 -05:00
Code Issues Activity
forgejo/web_src/js/features
History
wxiaoguang d4f35bd681
Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542) 
This PR follows #22599 and #23450

The major improvements:

1. The `aria-*.js` are totally transparent now, no need to call
`attachDropdownAria` explicitly anymore.
* It hooks the `$.fn.checkbox` and `$.fn.dropdown`, then our patch
works.
* It makes all dynamically generated checkbox/dropdown work with a11y
without any change
* eg: the `conversation.find('.dropdown').dropdown();` in `repo-diff.js`
2. Since it's totally transparent now, it could be easier to modify or
remove in the future.
3. It handles all selection labels as well (by onLabelCreate), so it
supports "multiple selection dropdown" now.
* It partially completes one of my TODOs: `TODO: multiple selection is
not supported yet.`
4. The code structure is clearer, code blocks are splitted into
different functions.
* The old `attachOneDropdownAria` was splitted into separate functions.
* It makes it easier to add more fine tunes in the future, and co-work
with contributors.
6. The code logic is similar as before, only two new parts: 
    1. the `ariaCheckboxFn` and `ariaDropdownFn` functions
    2. the `onLabelCreate` and `updateSelectionLabel` functions

In `aria-dropdown.js` I had to mix jQuery and Vanilla JS somewhat, I
think the code is still understandable, otherwise the code would be much
more complex to read.

Thanks to fsologureng for the idea about "improving the 'delete icon'
with aria attributes".

If there is anything unclear or incorrect, feel free to ask and discuss,
or propose new PRs for it.
2023-03-22 10:52:01 +08:00
..
admin Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
comp Scoped labels: set aria-disabled on muted Exclusive option for a11y (#23306) 2023-03-05 21:25:25 +08:00
captcha.js Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
citation.js Fix switched citation format (#23250) 2023-03-02 13:08:02 -06:00
clipboard.js Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
codeeditor.js Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) 2022-11-09 18:02:19 +08:00
colorpicker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
common-global.js Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542) 2023-03-22 10:52:01 +08:00
common-issue.js Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
common-organization.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
contextpopup.js Change interactiveBorder to fix popup preview (#23169) 2023-03-05 23:40:50 +08:00
copycontent.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
dropzone.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
emoji.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
eventsource.sharedworker.js Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) 2022-08-03 22:58:27 +03:00
file-fold.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
formatting.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
heatmap.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
imagediff.js Fix various ImageDiff/SVG bugs (#23312) 2023-03-07 20:11:24 +08:00
install.js Fix various bugs for "install" page (#23194) 2023-03-04 10:12:02 +08:00
notification.js Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
org-team.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
pull-view-file.js Replace unstyled meter with progress (#19968) 2022-06-15 12:28:24 +08:00
repo-branch.js Add apply-patch, basic revert and cherry-pick functionality (#17902) 2022-02-09 20:28:55 +00:00
repo-code.js Fix links for the menus in the view file page (#22795) 2023-02-08 00:08:44 +08:00
repo-code.test.js Ignore line anchor links with leading zeroes (#21728) 2022-11-11 18:22:36 +08:00
repo-commit.js Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
repo-common.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-diff-filetree.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-diff.js Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 2023-03-04 02:13:37 -05:00
repo-editor.js Support paste treepath when creating a new file or updating the file name (#23209) 2023-03-03 17:28:20 -05:00
repo-findfile.js Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00
repo-findfile.test.js Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00
repo-graph.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-home.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-issue-content.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-issue-pr-form.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
repo-issue.js Fix JS error on compare page (#23551) 2023-03-18 17:08:38 -04:00
repo-legacy.js Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 2023-03-17 11:08:05 +08:00
repo-migrate.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-migration.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-projects.js Sync the class change of Edit Column Button to JS code (#23400) 2023-03-12 19:09:20 +08:00
repo-release.js Hide target selector if tag exists when creating new release (#23171) 2023-03-10 10:42:38 -06:00
repo-settings.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2022-06-03 17:38:26 -04:00
repo-template.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-unicode-escape.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
repo-wiki.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2022-06-29 01:52:58 +08:00
serviceworker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
sshkey-helper.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
stopwatch.js Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
tablesort.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
tribute.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
user-auth-webauthn.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
user-auth.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
user-settings.js Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00