0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 15:23:14 -05:00
forgejo/models
Earl Warren ceea9c4334
Revert "avoid superfluous synchronized pull_request run when opening a PR"
The fix against the race incorrectly assumes the sha of the commit being
pushed belongs to the base repository. It finds the highest possible
pull request ID from the head repository instead of looking it up in
the base repository.

Figuring out if a PR was created in the future based on the highest
index of the base repository would require collecting all of them
because there is no way to know in advance which repository may be
involved in the race.

Fixing this race can be done either by:

* Introducing a new field in the pull_request table https://codeberg.org/forgejo/forgejo/pulls/2842
  which feels more like a hack than a real solution
* Refactoring the logic
  which would be a significant undertaking

The race has been in the codebase for a very long time and manifests
itself in the CI, when events happen in quick succession. The only
concrete manifestation was however fixed by https://codeberg.org/forgejo/forgejo/issues/2009

Since this race now only exists in theory and not in practice, let's
revert this bugous commit until a proper solution is implemented.

Fixes: https://codeberg.org/forgejo/forgejo/issues/2817

This reverts commit 036f1eddc5.

Conflicts:
	services/pull/pull.go
2024-03-28 07:08:17 +01:00
..
actions Cancel previous runs of the same PR automatically (#29961) 2024-03-26 16:51:56 +01:00
activities Performance improvements for pull request list page (#29900) 2024-03-26 19:04:26 +01:00
admin Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
asymkey Fix some pending problems (#29985) 2024-03-26 19:04:26 +01:00
auth remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
avatars Replace 10 more gt- classes with tw- (#29945) 2024-03-26 19:04:27 +01:00
db Partially enable MSSQL case-sensitive collation support (#29238) 2024-03-11 23:36:59 +07:00
dbfs make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
fixtures [REFACTOR] webhook.Handler interface 2024-03-24 10:35:06 +01:00
forgejo/semver [SEMVER] store SemVer in ForgejoSemVer after a database upgrade 2024-02-05 14:44:33 +01:00
forgejo_migrations models/forgejo_migrations: Gitea tables migration ID 2024-03-27 09:27:32 +01:00
git Fix schedule tasks bugs (#28691) 2024-03-25 16:25:02 +01:00
issues Revert "avoid superfluous synchronized pull_request run when opening a PR" 2024-03-28 07:08:17 +01:00
migrations Add a migration to remove SSH signatures from release notes 2024-03-26 08:09:36 +00:00
organization Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (#30013) 2024-03-26 19:04:28 +01:00
packages Fix incorrect relative/absolute URL usages (#29531) 2024-03-06 12:10:46 +08:00
perm Users with read permission of pull requests can be assigned too (#27263) 2024-02-26 22:30:27 +01:00
project Partially enable MSSQL case-sensitive collation support (#29238) 2024-03-11 23:36:59 +07:00
pull [GITEA] GetScheduledMergeByPullID may involve a system user 2024-02-05 16:09:41 +01:00
repo Fix schedule tasks bugs (#28691) 2024-03-25 16:25:02 +01:00
secret Make runs-on support variable expression (#29468) 2024-03-11 23:36:59 +07:00
shared/types Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
system Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
unit Add a direct link from repo header to unit settings 2024-02-13 22:42:09 +01:00
unittest [Windows] prevent ? in testdata path 2024-03-15 13:15:46 +01:00
user Fix user id column case (#29863) 2024-03-26 19:04:25 +01:00
webhook Merge pull request '[TESTS] fail when log.Error is called' (#2657) from oliverpool/forgejo:fail_test_on_log_error into forgejo 2024-03-24 07:28:31 +00:00
error.go Add merge style fast-forward-only (#28954) 2024-02-14 17:19:19 +01:00
fixture_generation.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
fixture_test.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
org.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
org_team.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
org_team_test.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
org_test.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
repo.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
repo_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
repo_transfer.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
repo_transfer_test.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00