0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 07:43:18 -05:00
forgejo/models/fixtures
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-10-24 15:59:24 +08:00
..
access.yml
access_token.yml
action.yml
attachment.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
collaboration.yml
comment.yml
commit_status.yml
commit_status_index.yml
deleted_branch.yml
deploy_key.yml
email_address.yml
external_login_user.yml
follow.yml
foreign_reference.yml
gpg_key.yml
gpg_key_import.yml
hook_task.yml Decouple HookTask from Repository (#17940) 2022-10-21 18:21:56 +02:00
issue.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
issue_assignees.yml
issue_index.yml
issue_label.yml
issue_user.yml
issue_watch.yml
label.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
login_source.yml
milestone.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
notice.yml
notification.yml
oauth2_application.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_authorization_code.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_grant.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
org_user.yml
project.yml
project_board.yml
project_issue.yml
protected_branch.yml
public_key.yml
pull_request.yml Add API endpoint to get changed files of a PR (#21177) 2022-09-29 04:27:20 +02:00
reaction.yml
release.yml
renamed_branch.yml
repo_archiver.yml
repo_indexer_status.yml
repo_redirect.yml
repo_topic.yml
repo_transfer.yml
repo_unit.yml
repository.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
review.yml
star.yml
stopwatch.yml
system_setting.yml Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
team.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
team_repo.yml
team_unit.yml
team_user.yml
topic.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
tracked_time.yml
two_factor.yml
user.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
user_open_id.yml
user_redirect.yml
watch.yml
webauthn_credential.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
webhook.yml