0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-28 10:24:11 -05:00
forgejo/modules
Earl Warren 50822f361e
Do not update PRs based on events that happened before they existed
* Split TestPullRequest out of AddTestPullRequestTask
* A Created field is added to the Issue table
* The Created field is set to the time (with nano resolution) on creation
* Record the nano time repo_module.PushUpdateOptions is created by the hook
* The decision to update a pull request created before a commit was
  pushed is based on the time (with nano resolution) the git hook
  was run and the Created field

It ensures the following happens:

* commit C is pushed
* the git hook queues AddTestPullRequestTask for processing and returns with success
* TestPullRequest is not called yet
* a pull request P with commit C as the head is created
* TestPullRequest runs and ignores P because it was created after the commit was received

When the "created" column is NULL, no verification is done, pull
requests that were created before the column was created in the
database cannot be newer than the latest call to a git hook.

Fixes: https://codeberg.org/forgejo/forgejo/issues/2009
(cherry picked from commit 998a431747)

Conflicts:
	models/forgejo_migrations/migrate.go
	see https://codeberg.org/forgejo/forgejo/pulls/3165#issuecomment-1755941
	services/pull/pull.go
	trivial conflicts
2024-04-12 10:41:19 +02:00
..
actions Merge pull request '[ACTIONS] port scheduled actions from Gitea' (#2826) from earl-warren/forgejo:wip-gitea-schedule into forgejo 2024-03-27 06:23:56 +00:00
activitypub
analyze
assetfs
auth
avatar
base Refactor StringsToInt64s (#29967) 2024-03-26 19:04:26 +01:00
cache
charset
container
csv
emoji
eventsource
generate
git [BUG] Handle bigger files in git grep 2024-04-11 13:32:01 +00:00
gitgraph models/asymkey: Implement Tag verification 2024-04-01 13:42:11 +00:00
gitrepo Move get/set default branch from git package to gitrepo package to hide repopath (#29126) 2024-03-11 23:36:59 +07:00
graceful [FIX] make pprof labels conformant with prometheus spec 2024-04-01 18:22:11 +00:00
hcaptcha
highlight
hostmatcher
html
httpcache
httplib
indexer Remove error check 2024-04-10 17:43:57 +00:00
issue/template Extend issue template yaml engine (#29274) 2024-03-06 12:10:47 +08:00
json
label
lfs Close file in the Upload func (#30262) (#30270) 2024-04-08 11:50:17 +02:00
log
markup Fixes #27605: inline math blocks can't be preceeded/followed by alphanumerical characters (#30175) (#30251) 2024-04-08 11:49:51 +02:00
mcaptcha
metrics
migration
nosql
optional migrate some more "OptionalBool" to "Option[bool]" (#29479) 2024-03-06 12:10:44 +08:00
options
packages feat: improve nuget nuspec api 2024-04-06 08:32:53 +00:00
paginator
pprof
private
process [FIX] make pprof labels conformant with prometheus spec 2024-04-01 18:22:11 +00:00
proxy
proxyprotocol
public
queue workergroup: gracefully exit on close(popItemErr) 2024-03-24 07:12:31 +01:00
recaptcha
references Fix issue link does not support quotes (#29484) (#29487) 2024-03-06 12:10:45 +08:00
regexplru
repository Do not update PRs based on events that happened before they existed 2024-04-12 10:41:19 +02:00
secret
session
setting [FEAT] Support Include/Exclude Filters for Grep (#3058) 2024-04-06 17:38:32 +00:00
sitemap
ssh
storage Add minio bucket lookup type option 2024-03-06 09:38:02 +00:00
structs [v7.0/forgejo] Add optional pronoun field in user settings (#3076) 2024-04-06 13:23:43 +00:00
svg
sync
system
templates Add opacity and grayscale to archived labels 2024-04-03 20:14:39 +00:00
test
testlogger Merge pull request '[v7.0/forgejo] [FEAT] Mark database errors in tests as failure' (#2978) from bp-v7.0/forgejo-2dabd20 into v7.0/forgejo 2024-04-02 15:53:23 +00:00
timeutil Remove the time-since class (#29826) 2024-03-20 08:46:30 +01:00
translation Rename ByteSize to ReadableSize 2024-04-02 17:29:32 +00:00
turnstile
typesniffer
updatechecker
uri
user
util Revert "cherry pick only IfZero from (#29755)" 2024-03-28 11:46:41 +00:00
validation
web [REFACTOR] webhook matrix endpoints 2024-03-27 15:38:38 +01:00
webhook [FEAT] sourcehut webhooks 2024-04-05 19:36:04 +00:00