0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-01-07 23:20:48 -05:00
forgejo/services
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
actions [ACTIONS] skip superflous pull request synchronized event (#2314) 2024-02-13 12:00:27 +01:00
agit
asymkey
attachment
auth [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
automerge
context
convert Fix convert.ToTeams on empty input (#28426) (#28767) 2024-01-16 14:39:23 +00:00
cron [GITEA] Actually recover from a panic in cron task 2023-12-10 17:20:49 +01:00
externalaccount
feed
forgejo
forms [GITEA] Fix required error for token name 2023-11-13 14:06:32 +01:00
gitdiff [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
indexer Fix missing issue search index update when changing status (#28325) (#28330) 2023-12-08 13:41:16 +01:00
issue [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
lfs [GITEA] Drop sha256-simd in favor of stdlib 2023-11-13 14:06:31 +01:00
mailer Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
markup
migrations Only migrate the first 255 chars of a Github issue title (#28902) (#28912) 2024-01-31 14:18:26 +01:00
mirror
notify [GITEA] notifies admins on new user registration 2023-11-13 14:06:27 +01:00
org
packages [GITEA] Generate install if condition for Alpine 2024-02-03 19:30:48 +01:00
pull Concatenate error in checkIfPRContentChanged (#28731) (#28737) 2024-01-16 14:39:23 +00:00
release Avoid sending update/delete release notice when it is draft (#29008) (#29025) 2024-02-13 14:17:34 +01:00
repository [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
secrets
task
uinotification
user Forbid removing the last admin user (#28337) (#28793) 2024-01-16 14:41:11 +00:00
webhook Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
wiki