0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-27 09:54:15 -05:00
forgejo/routers/web/repo
Giteabot 203fe2841d
Fix Permission in API returned repository struct (#25388) (#25441)
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
..
actions Add step start time to ViewStepLog (#24980) 2023-05-29 08:18:36 +00:00
setting Add user level action runners (#24995) 2023-05-31 09:39:54 +08:00
activity.go
attachment.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2023-06-14 08:36:52 +02:00
blame.go Sort repo topic labels by name (#24123) 2023-04-14 15:29:05 -04:00
branch.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
cherry_pick.go
commit.go Pass 'not' to commit count (#24473) 2023-05-08 07:10:53 +00:00
compare.go Don't list root repository on compare page if pulls not allowed (#24183) 2023-04-19 11:16:46 -04:00
download.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2023-06-14 08:36:52 +02:00
editor.go Fix blank dir message when uploading files from web editor (#25391) (#25400) 2023-06-20 20:28:52 +00:00
editor_test.go
find.go
helper.go Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890) 2023-04-07 08:11:02 +08:00
helper_test.go Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890) 2023-04-07 08:11:02 +08:00
http.go Redesign Scoped Access Tokens (#24767) 2023-06-04 20:57:16 +02:00
http_test.go
issue.go Fix MilestoneIDs when querying issues (#25125) (#25141) 2023-06-08 11:03:53 +02:00
issue_content_history.go
issue_dependency.go Add API to manage issue dependencies (#17935) 2023-03-28 13:23:25 -04:00
issue_label.go Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
issue_label_test.go Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
issue_lock.go
issue_pin.go Followup to pinned Issues (#24945) 2023-05-30 15:26:51 +00:00
issue_stopwatch.go
issue_test.go
issue_timetrack.go
issue_watch.go Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
lfs.go Introduce path Clean/Join helper functions (#23495) 2023-03-21 16:02:49 -04:00
main_test.go
middlewares.go Show outdated comments in files changed tab (#24936) (#25428) 2023-06-22 08:34:42 +00:00
migrate.go Make repo migration cancelable and fix various bugs (#24605) 2023-05-11 08:25:46 +00:00
milestone.go Improve Gitea's web context, decouple "issue template" code into service package (#24590) 2023-05-09 01:30:14 +02:00
packages.go
patch.go
projects.go Merge new project templates into one (#24985) 2023-05-31 08:50:18 +02:00
projects_test.go
pull.go Show outdated comments in files changed tab (#24936) (#25428) 2023-06-22 08:34:42 +00:00
pull_review.go Show outdated comments in files changed tab (#24936) (#25428) 2023-06-22 08:34:42 +00:00
release.go fix: release page for empty or non-existing target (#24470) 2023-05-10 11:43:55 +08:00
release_test.go fix: release page for empty or non-existing target (#24470) 2023-05-10 11:43:55 +08:00
render.go
repo.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2023-06-14 08:36:52 +02:00
search.go
setting.go Hide 'Mirror Settings' when unneeded, improve hints (#24433) 2023-05-29 11:32:52 +00:00
setting_protected_branch.go Support for status check pattern (#24633) 2023-05-17 16:11:13 +08:00
settings_test.go
tag.go
topic.go
treelist.go
view.go Show if File is Executable (#25287) (#25300) 2023-06-16 09:29:26 +00:00
view_test.go
webhook.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
wiki.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
wiki_test.go Make wiki title supports dashes and improve wiki name related features (#24143) 2023-04-19 13:50:10 -04:00