0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-01-15 10:54:47 -05:00
forgejo/routers/api/v1/repo
Giteabot 203fe2841d
Fix Permission in API returned repository struct (#25388) (#25441)
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
..
blob.go
branch.go Create a branch directly from commit on the create branch API (#22956) 2023-05-09 18:22:32 +08:00
collaborators.go
commits.go Filter get single commit (#24613) 2023-05-10 09:34:07 +08:00
file.go Fix all possible setting error related storages and added some tests (#23911) (#25244) 2023-06-14 08:36:52 +02:00
fork.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
git_hook.go
git_ref.go
hook.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
hook_test.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
issue.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
issue_attachment.go
issue_comment.go Use CommentList instead of []*Comment (#24828) 2023-05-21 20:48:28 +08:00
issue_comment_attachment.go
issue_dependency.go
issue_label.go
issue_pin.go Followup to pinned Issues (#24945) 2023-05-30 15:26:51 +00:00
issue_reaction.go
issue_stopwatch.go
issue_subscription.go
issue_tracked_time.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
key.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
label.go
language.go
main_test.go
migrate.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
milestone.go
mirror.go
notes.go Filters for GetAllCommits (#24568) 2023-05-09 09:06:05 +08:00
patch.go
pull.go Filters for GetAllCommits (#24568) 2023-05-09 09:06:05 +08:00
pull_review.go
release.go
release_attachment.go
release_tags.go
repo.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
repo_test.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
star.go
status.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
subscriber.go
tag.go
teams.go
topic.go
transfer.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
tree.go
wiki.go