mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-01-29 09:48:54 -05:00
5ddf67a9c2
Backport #23014 As the title. Label/assignee share the same code. * Close #22607 * Close #20727 Also: * partially fix for #21742, now the comment reaction and menu work with keyboard. * partially fix for #17705, in most cases the comment won't be lost. * partially fix for #21539 * partially fix for #20347 * partially fix for #7329 ### The `Enter` support Before, if user presses Enter, the dropdown just disappears and nothing happens or the window reloads. After, Enter can be used to select/deselect labels, and press Esc to hide the dropdown to update the labels (still no way to cancel .... maybe you can do a Cmd+R or F5 to refresh the window to discard the changes .....) This is only a quick patch, the UX is still not perfect, but it's much better than before. ### The `confirm` before reloading And more fixes for the `reload` problem, the new behaviors: * If nothing changes (just show/hide the dropdown), then the page won't be reloaded. * If there are draft comments, show a confirm dialog before reloading, to avoid losing comments. That's the best effect can be done at the moment, unless completely refactor these dropdown related code. Screenshot of the confirm dialog: <details>  </details> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Brecht Van Lommel <brecht@blender.org> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> |
||
|---|---|---|
| .. | ||
| admin | ||
| comp | ||
| aria.js | ||
| aria.md | ||
| captcha.js | ||
| citation.js | ||
| clipboard.js | ||
| codeeditor.js | ||
| colorpicker.js | ||
| common-global.js | ||
| common-issue.js | ||
| common-organization.js | ||
| contextpopup.js | ||
| copycontent.js | ||
| dropzone.js | ||
| emoji.js | ||
| eventsource.sharedworker.js | ||
| file-fold.js | ||
| formatting.js | ||
| heatmap.js | ||
| imagediff.js | ||
| install.js | ||
| notification.js | ||
| org-team.js | ||
| pull-view-file.js | ||
| repo-branch.js | ||
| repo-code.js | ||
| repo-code.test.js | ||
| repo-commit.js | ||
| repo-common.js | ||
| repo-diff-filetree.js | ||
| repo-diff.js | ||
| repo-editor.js | ||
| repo-findfile.js | ||
| repo-findfile.test.js | ||
| repo-graph.js | ||
| repo-home.js | ||
| repo-issue-content.js | ||
| repo-issue-pr-form.js | ||
| repo-issue.js | ||
| repo-legacy.js | ||
| repo-migrate.js | ||
| repo-migration.js | ||
| repo-projects.js | ||
| repo-release.js | ||
| repo-settings.js | ||
| repo-template.js | ||
| repo-unicode-escape.js | ||
| repo-wiki.js | ||
| serviceworker.js | ||
| sshkey-helper.js | ||
| stopwatch.js | ||
| tablesort.js | ||
| tribute.js | ||
| user-auth-webauthn.js | ||
| user-auth.js | ||
| user-settings.js | ||
