0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 15:53:07 -05:00
forgejo/web_src/js/modules
silverwind a01387f5b1
Add form field id generation, remove duplicated ids (#30546)
Fixes: https://github.com/go-gitea/gitea/issues/30384

On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.

Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.

I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)

Conflicts:
	- templates/repo/settings/options.tmpl
	  Conflict resolved by manually removing all `id` and `for`
	  attributes from elements that had `repo_name` as their id.
2024-04-22 08:09:00 +02:00
..
fomantic Add form field id generation, remove duplicated ids (#30546) 2024-04-22 08:09:00 +02:00
dirauto.js [gitea] Avoid showing unnecessary JS errors when there are elements with different origin on the page (#29081) 2024-02-10 10:53:43 +01:00
fetch.js Refactor request function (#29187) 2024-02-17 23:24:31 +01:00
fetch.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
fomantic.js Add form field id generation, remove duplicated ids (#30546) 2024-04-22 08:09:00 +02:00
sortable.js Drag-and-drop improvements for projects and issue pins (#29875) 2024-03-30 07:17:31 +01:00
stores.js
tippy.js Replace coloris with vanilla-colorful (#30201) 2024-04-07 15:40:31 +02:00
toast.js Remove most jQuery function calls from the repository topic box (#30191) 2024-04-07 15:40:31 +02:00
toast.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00