mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 23:33:15 -05:00
f01dc4b271
cmd/dump.go uses os.Readdir to list the directory.
This is fine on its own, but TestAddRecursiveExclude in cmd/dump_test.go
depends on the order of the directory listing, which is where the issue
lays.
Directory listings using os.Readdir (lstat) don't actually guarantee an
order. They can differ due to a number of factors. Most notably the OS,
file system and settings.
As such, the test should not check the /order of the files/ added to the
archive, but instead simply check whether the archive /contains/ them.
So this is precisely what this commit does.
Note that only TestAddRecursiveExclude/File_inside_directory/No_exclude
has been observed to fail due to this, but all TestAddRecursiveExclude
subtests have been updated for consistency.
(cherry picked from commit
|
||
---|---|---|
.. | ||
forgejo | ||
actions.go | ||
admin.go | ||
admin_auth.go | ||
admin_auth_ldap.go | ||
admin_auth_ldap_test.go | ||
admin_auth_oauth.go | ||
admin_auth_stmp.go | ||
admin_regenerate.go | ||
admin_user.go | ||
admin_user_change_password.go | ||
admin_user_create.go | ||
admin_user_delete.go | ||
admin_user_generate_access_token.go | ||
admin_user_list.go | ||
admin_user_must_change_password.go | ||
cert.go | ||
cmd.go | ||
docs.go | ||
doctor.go | ||
doctor_convert.go | ||
doctor_test.go | ||
dump.go | ||
dump_repo.go | ||
dump_test.go | ||
embedded.go | ||
generate.go | ||
hook.go | ||
hook_test.go | ||
keys.go | ||
mailer.go | ||
main.go | ||
main_test.go | ||
manager.go | ||
manager_logging.go | ||
migrate.go | ||
migrate_storage.go | ||
migrate_storage_test.go | ||
restore_repo.go | ||
serv.go | ||
web.go | ||
web_acme.go | ||
web_graceful.go | ||
web_https.go |