mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-26 01:14:10 -05:00
affdd40296
Replace #19922 , which is stale since my last review: https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506 and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546 Close #19769 Changes: 1. Use `<button>` instead of `<div>` for buttons 2. Prevent default event handler in `initGlobalButtonClickOnEnter` 3. Fix the incorrect call to `pullrequest_targetbranch_change` 4. Add a slight margin-left to the input element to make UI look better The logic in repo-issue.js is not ideal, but this PR isn't going to touch the logic. This is also an example for future developers to understand how to make buttons work properly. ### Before ![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png) ### After * Add a slight margin-left. * The `Cancel` button is focused. ![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png) Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
||
---|---|---|
.. | ||
fields | ||
labels | ||
view_content | ||
branch_selector_field.tmpl | ||
choose.tmpl | ||
comment_tab.tmpl | ||
label_precolors.tmpl | ||
labels.tmpl | ||
list.tmpl | ||
milestone_issues.tmpl | ||
milestone_new.tmpl | ||
milestones.tmpl | ||
navbar.tmpl | ||
new.tmpl | ||
new_form.tmpl | ||
openclose.tmpl | ||
search.tmpl | ||
view.tmpl | ||
view_content.tmpl | ||
view_title.tmpl |