0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 08:06:49 -05:00
forgejo/routers/api/v1
qwerty287 9d943bf374
Add missing X-Total-Count and fix some related bugs (#17968)
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
admin Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
misc Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
notify Fix 500 when a comment was deleted which has a notification (#17550) 2021-11-10 13:48:45 +08:00
org Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
repo Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
settings Make mirror feature more configurable (#16957) 2021-09-07 17:49:36 +02:00
swagger Add API to get/edit wiki (#17278) 2021-10-25 11:43:40 +08:00
user Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
utils Use a standalone struct name for Organization (#17632) 2021-11-19 19:41:40 +08:00
api.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00