Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 16:16:35 -05:00
Code Issues Activity
forgejo/modules/graceful
History
wxiaoguang a8f5449cd9
Avoid unexpected panic in graceful manager (#29629) 
There is a fundamental design problem of the "manager" and the "wait
group".
If nothing has started, the "Wait" just panics: sync: WaitGroup is
reused before previous Wait has returned
There is no clear solution besides a complete rewriting of the "manager"

If there are some mistakes in the app.ini, end users would just see the
"panic", but not the real error messages. A real case: #27643

This PR is just a quick fix for the annoying panic problem.

(cherry picked from commit 90a3f2d4b7ed3890d9655c0334444f86d89b7b30)
2024-03-11 23:36:58 +07:00
..
releasereopen
context.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
manager.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
manager_common.go Suggest to use Type=simple for systemd service (#28717) 2024-01-07 15:18:04 +00:00
manager_unix.go Avoid unexpected panic in graceful manager (#29629) 2024-03-11 23:36:58 +07:00
manager_windows.go Avoid unexpected panic in graceful manager (#29629) 2024-03-11 23:36:58 +07:00
net_unix.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
net_windows.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
restart_unix.go
server.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
server_hooks.go
server_http.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00