0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 15:53:07 -05:00
forgejo/modules
wxiaoguang a8f5449cd9
Avoid unexpected panic in graceful manager (#29629)
There is a fundamental design problem of the "manager" and the "wait
group".
If nothing has started, the "Wait" just panics: sync: WaitGroup is
reused before previous Wait has returned
There is no clear solution besides a complete rewriting of the "manager"

If there are some mistakes in the app.ini, end users would just see the
"panic", but not the real error messages. A real case: #27643

This PR is just a quick fix for the annoying panic problem.

(cherry picked from commit 90a3f2d4b7ed3890d9655c0334444f86d89b7b30)
2024-03-11 23:36:58 +07:00
..
actions Set pre-step status to skipped if job is skipped (#29489) 2024-03-06 12:10:45 +08:00
activitypub
analyze
assetfs
auth Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
avatar
base [FEAT] Show follow symlink button 2024-03-02 17:58:09 +01:00
cache
charset [FEAT] Enable ambiguous character detection in configured contexts 2024-02-23 13:12:17 +01:00
container
csv Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
emoji
eventsource
generate Port "Use general token signing secret" 2024-02-19 20:49:37 +01:00
git Add a check for when the command is canceled by the program on Window… (#29538) 2024-03-06 12:10:45 +08:00
gitgraph
gitrepo
graceful Avoid unexpected panic in graceful manager (#29629) 2024-03-11 23:36:58 +07:00
hcaptcha
highlight
hostmatcher
html
httpcache
httplib
indexer [PORT] Fix wrong line number in code search result (gitea#29260) (#2619) 2024-03-10 15:35:30 +00:00
issue/template Extend issue template yaml engine (#29274) 2024-03-06 12:10:47 +08:00
json
label
lfs
log
markup Port "Fix wrong test usage of AppSubURL" 2024-03-06 21:47:44 +01:00
mcaptcha
metrics
migration Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
nosql
optional migrate some more "OptionalBool" to "Option[bool]" (#29479) 2024-03-06 12:10:44 +08:00
options
packages
paginator
pprof
private
process
proxy
proxyprotocol
public
queue Fix queue worker incorrectly stopped when there are still more items in the queue (#29532) 2024-03-06 12:10:46 +08:00
recaptcha
references Fix issue link does not support quotes (#29484) (#29487) 2024-03-06 12:10:45 +08:00
regexplru
repository Move generate from module to service (#29465) 2024-03-06 12:10:44 +08:00
secret
session
setting Allow options to disable user ssh keys configuration from the interface on app.ini (#29447) 2024-03-11 23:36:57 +07:00
sitemap
ssh
storage
structs Extend issue template yaml engine (#29274) 2024-03-06 12:10:47 +08:00
svg
sync
system
templates Remove unnecessary SanitizeHTML from code (#29575) 2024-03-11 23:36:58 +07:00
test
testlogger
timeutil Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
translation Add an trailing slash to dashboard links (#29555) 2024-03-06 12:10:47 +08:00
turnstile
typesniffer
updatechecker
uri
user
util remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
validation
web Refactor locale&string&template related code (#29165) 2024-02-16 15:20:52 +01:00
webhook