0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-26 01:14:10 -05:00
forgejo/services/repository
Christian Ullrich 84285a1169
Do not list active repositories as unadopted (#22034)
This fixes a bug where, when searching unadopted repositories, active
repositories will be listed as well. This is because the size of the
array of repository names to check is larger by one than the
`IterateBufferSize`.

For an `IterateBufferSize` of 50, the original code will pass 51
repository names but set the query to `LIMIT 50`. If all repositories in
the query are active (i.e. not unadopted) one of them will be omitted
from the result. Due to the `ORDER BY` clause it will be the oldest (or
least recently modified) one.

Bug found in 1.17.3.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-12-16 16:58:56 +08:00
..
archiver refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
files refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
adopt.go Do not list active repositories as unadopted (#22034) 2022-12-16 16:58:56 +08:00
adopt_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
avatar.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
avatar_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
branch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
cache.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
check.go Add doctor command for full GC of LFS (#21978) 2022-12-15 20:44:16 +00:00
fork.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
fork_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hooks.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
lfs.go Add doctor command for full GC of LFS (#21978) 2022-12-15 20:44:16 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
push.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repository.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
repository_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
review.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
review_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
template.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
transfer.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
transfer_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00