mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-24 16:16:35 -05:00
525b7382d3
Use native instead of fomantic checkboxes in issue list. Benefits include no more JS pop-in on load and perfect a11y. Before, with JS pop-in: <img width="92" alt="Screenshot 2023-03-20 at 17 02 02" src="https://user-images.githubusercontent.com/115237/226398955-99029a1c-1150-449c-821b-e4165e7446a8.png"> After, Firefox on macOS: <img width="126" alt="Screenshot 2023-03-20 at 17 01 26" src="https://user-images.githubusercontent.com/115237/226399018-58df2c32-c2b2-4c78-b7df-7b76523abe21.png"> After, Chrome on macOS: <img width="79" alt="Screenshot 2023-03-20 at 17 01 42" src="https://user-images.githubusercontent.com/115237/226399074-947e6279-8dc3-42c2-90b5-b106c471b23d.png"> I opted to not do styling yet but I see that the inconsistency between browsers may already be reason enough on doing it. I think if we style them, there should be one global style, including markdown ones which currently have custom styling.
178 lines
7.4 KiB
Handlebars
178 lines
7.4 KiB
Handlebars
<div class="issue list">
|
|
{{$approvalCounts := .ApprovalCounts}}
|
|
{{range .Issues}}
|
|
<li class="item gt-df gt-py-3">
|
|
<div class="issue-item-left gt-df gt-items-start">
|
|
{{if $.CanWriteIssuesOrPulls}}
|
|
<input type="checkbox" autocomplete="off" class="issue-checkbox gt-mt-2 gt-mr-4" data-issue-id={{.ID}} aria-label="{{$.locale.Tr "repo.issues.action_check"}} "{{.Title}}"">
|
|
{{end}}
|
|
<div class="issue-item-icon">
|
|
{{if .IsPull}}
|
|
{{if .PullRequest.HasMerged}}
|
|
{{svg "octicon-git-merge" 16 "text purple"}}
|
|
{{else}}
|
|
{{if .IsClosed}}
|
|
{{svg "octicon-git-pull-request" 16 "text red"}}
|
|
{{else}}
|
|
{{if .PullRequest.IsWorkInProgress}}
|
|
{{svg "octicon-git-pull-request-draft" 16 "text grey"}}
|
|
{{else}}
|
|
{{svg "octicon-git-pull-request" 16 "text green"}}
|
|
{{end}}
|
|
{{end}}
|
|
{{end}}
|
|
{{else}}
|
|
{{if .IsClosed}}
|
|
{{svg "octicon-issue-closed" 16 "text red"}}
|
|
{{else}}
|
|
{{svg "octicon-issue-opened" 16 "text green"}}
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
<div class="issue-item-main gt-f1 gt-fc gt-df">
|
|
<div class="issue-item-top-row">
|
|
<a class="title gt-tdn issue-title" href="{{if .Link}}{{.Link}}{{else}}{{$.Link}}/{{.Index}}{{end}}">{{RenderEmoji $.Context .Title | RenderCodeBlock}}</a>
|
|
{{if .IsPull}}
|
|
{{if (index $.CommitStatuses .PullRequest.ID)}}
|
|
{{template "repo/commit_statuses" dict "Status" (index $.CommitLastStatus .PullRequest.ID) "Statuses" (index $.CommitStatuses .PullRequest.ID) "root" $}}
|
|
{{end}}
|
|
{{end}}
|
|
<span class="labels-list gt-ml-2">
|
|
{{range .Labels}}
|
|
<a href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&state={{$.State}}&labels={{.ID}}{{if ne $.listType "milestone"}}&milestone={{$.MilestoneID}}{{end}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{RenderLabel $.Context .}}</a>
|
|
{{end}}
|
|
</span>
|
|
</div>
|
|
<div class="desc issue-item-bottom-row gt-df gt-ac gt-fw gt-my-1">
|
|
<a class="index gt-ml-0 gt-mr-2" href="{{if .Link}}{{.Link}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
|
|
{{if eq $.listType "dashboard"}}
|
|
{{.Repo.FullName}}#{{.Index}}
|
|
{{else}}
|
|
#{{.Index}}
|
|
{{end}}
|
|
</a>
|
|
{{$timeStr := TimeSinceUnix .GetLastEventTimestamp $.locale}}
|
|
{{if .OriginalAuthor}}
|
|
{{$.locale.Tr .GetLastEventLabelFake $timeStr (.OriginalAuthor|Escape) | Safe}}
|
|
{{else if gt .Poster.ID 0}}
|
|
{{$.locale.Tr .GetLastEventLabel $timeStr (.Poster.HomeLink|Escape) (.Poster.GetDisplayName | Escape) | Safe}}
|
|
{{else}}
|
|
{{$.locale.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName | Escape) | Safe}}
|
|
{{end}}
|
|
{{if .IsPull}}
|
|
<div class="branches gt-df gt-ac">
|
|
<div class="branch">
|
|
<a href="{{.PullRequest.BaseRepo.Link}}/src/branch/{{PathEscapeSegments .PullRequest.BaseBranch}}">
|
|
{{/* inline to remove the spaces between spans */}}
|
|
{{if ne .RepoID .PullRequest.BaseRepoID}}<span class="truncated-name">{{.PullRequest.BaseRepo.OwnerName}}</span>:{{end}}<span class="truncated-name">{{.PullRequest.BaseBranch}}</span>
|
|
</a>
|
|
</div>
|
|
{{svg "gitea-double-chevron-left" 12 "gt-mx-1"}}
|
|
{{if .PullRequest.HeadRepo}}
|
|
<div class="branch">
|
|
<a href="{{.PullRequest.HeadRepo.Link}}/src/branch/{{PathEscapeSegments .PullRequest.HeadBranch}}">
|
|
{{/* inline to remove the spaces between spans */}}
|
|
{{if ne .RepoID .PullRequest.HeadRepoID}}<span class="truncated-name">{{.PullRequest.HeadRepo.OwnerName}}</span>:{{end}}<span class="truncated-name">{{.PullRequest.HeadBranch}}</span>
|
|
</a>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
{{end}}
|
|
{{if and .Milestone (ne $.listType "milestone")}}
|
|
<a class="milestone" {{if $.RepoLink}}href="{{$.RepoLink}}/milestone/{{.Milestone.ID}}"{{else}}href="{{.Repo.Link}}/milestone/{{.Milestone.ID}}"{{end}}>
|
|
{{svg "octicon-milestone" 14 "gt-mr-2"}}{{.Milestone.Name}}
|
|
</a>
|
|
{{end}}
|
|
{{if .Project}}
|
|
<a class="project" href="{{.Project.Link}}">
|
|
{{svg .Project.IconName 14 "gt-mr-2"}}{{.Project.Title}}
|
|
</a>
|
|
{{end}}
|
|
{{if .Ref}}
|
|
<a class="ref" {{if $.RepoLink}}href="{{index $.IssueRefURLs .ID}}"{{else}}href="{{.Repo.Link}}{{index $.IssueRefURLs .ID}}"{{end}}>
|
|
{{svg "octicon-git-branch" 14 "gt-mr-2"}}{{index $.IssueRefEndNames .ID}}
|
|
</a>
|
|
{{end}}
|
|
{{$tasks := .GetTasks}}
|
|
{{if gt $tasks 0}}
|
|
{{$tasksDone := .GetTasksDone}}
|
|
<span class="checklist">
|
|
{{svg "octicon-checklist" 14 "gt-mr-2"}}{{$tasksDone}} / {{$tasks}}
|
|
<progress value="{{$tasksDone}}" max="{{$tasks}}"></progress>
|
|
</span>
|
|
{{end}}
|
|
{{if ne .DeadlineUnix 0}}
|
|
<span class="due-date" data-tooltip-content="{{$.locale.Tr "repo.issues.due_date"}}">
|
|
<span{{if .IsOverdue}} class="overdue"{{end}}>
|
|
{{svg "octicon-calendar" 14 "gt-mr-2"}}
|
|
<time data-format="short-date" datetime="{{.DeadlineUnix.FormatDate}}">{{.DeadlineUnix.FormatShort}}</time>
|
|
</span>
|
|
</span>
|
|
{{end}}
|
|
{{if .IsPull}}
|
|
{{$approveOfficial := call $approvalCounts .ID "approve"}}
|
|
{{$rejectOfficial := call $approvalCounts .ID "reject"}}
|
|
{{$waitingOfficial := call $approvalCounts .ID "waiting"}}
|
|
{{if gt $approveOfficial 0}}
|
|
<span class="approvals gt-df gt-ac green">
|
|
{{svg "octicon-check" 14 "gt-mr-1"}}
|
|
{{$.locale.TrN $approveOfficial "repo.pulls.approve_count_1" "repo.pulls.approve_count_n" $approveOfficial}}
|
|
</span>
|
|
{{end}}
|
|
{{if gt $rejectOfficial 0}}
|
|
<span class="rejects gt-df gt-ac red">
|
|
{{svg "octicon-diff" 14 "gt-mr-2"}}
|
|
{{$.locale.TrN $rejectOfficial "repo.pulls.reject_count_1" "repo.pulls.reject_count_n" $rejectOfficial}}
|
|
</span>
|
|
{{end}}
|
|
{{if gt $waitingOfficial 0}}
|
|
<span class="waiting gt-df gt-ac">
|
|
{{svg "octicon-eye" 14 "gt-mr-2"}}
|
|
{{$.locale.TrN $waitingOfficial "repo.pulls.waiting_count_1" "repo.pulls.waiting_count_n" $waitingOfficial}}
|
|
</span>
|
|
{{end}}
|
|
{{if and (not .PullRequest.HasMerged) (gt (len .PullRequest.ConflictedFiles) 0)}}
|
|
<span class="conflicting gt-df gt-ac">
|
|
{{svg "octicon-x" 14}}
|
|
{{$.locale.TrN (len .PullRequest.ConflictedFiles) "repo.pulls.num_conflicting_files_1" "repo.pulls.num_conflicting_files_n" (len .PullRequest.ConflictedFiles)}}
|
|
</span>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
{{if or .TotalTrackedTime .Assignees .NumComments}}
|
|
<div class="issue-item-icons-right gt-df gt-p-2">
|
|
{{if .TotalTrackedTime}}
|
|
<div class="issue-item-icon-right text grey">
|
|
{{svg "octicon-clock" 16 "gt-mr-2"}}
|
|
{{.TotalTrackedTime | Sec2Time}}
|
|
</div>
|
|
{{end}}
|
|
{{if .Assignees}}
|
|
<div class="issue-item-icon-right text grey">
|
|
{{range .Assignees}}
|
|
<a class="ui assignee gt-tdn" href="{{.HomeLink}}" data-tooltip-content="{{.GetDisplayName}}">
|
|
{{avatar $.Context .}}
|
|
</a>
|
|
{{end}}
|
|
</div>
|
|
{{end}}
|
|
{{if .NumComments}}
|
|
<div class="issue-item-icon-right text grey">
|
|
<a class="gt-tdn muted" href="{{if .Link}}{{.Link}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
|
|
{{svg "octicon-comment" 16 "gt-mr-2"}}{{.NumComments}}
|
|
</a>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
{{end}}
|
|
</li>
|
|
{{end}}
|
|
{{if .IssueIndexerUnavailable}}
|
|
<div class="ui error message">
|
|
<p>{{$.locale.Tr "repo.issues.keyword_search_unavailable"}}</p>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
{{template "base/paginate" .}}
|