0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 08:54:17 -05:00
forgejo/routers/web
Eng Zer Jun 8b0aaa5f86
test: use T.TempDir to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
admin Redirect if user does not exist (#20981) 2022-08-29 15:44:39 +02:00
auth Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
dev Make better use of i18n (#20096) 2022-06-26 22:19:22 +08:00
events Improve Stopwatch behavior (#18930) 2022-04-25 22:45:22 +02:00
explore Only show relevant repositories on explore page (#19361) 2022-08-25 20:38:41 +02:00
feed Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
healthcheck Update go-chi/cache to utilize Ping() (#19719) 2022-05-15 20:43:27 +02:00
misc Fix panic in team repos API (#19431) 2022-04-20 18:43:26 +08:00
org Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
user Replace ServeStream with ServeContent (#20903) 2022-08-25 12:05:21 -04:00
auth.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
auth_windows.go
base.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
goget.go Refactor legacy unknwon/com package, improve golangci lint (#19284) 2022-04-01 16:47:50 +08:00
home.go Add sitemap support (#18407) 2022-06-25 19:06:01 +02:00
metrics.go
nodeinfo.go
swagger_json.go
web.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
webfinger.go Fix various typos (#20338) 2022-07-12 23:32:37 +02:00