0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-02-07 06:08:47 -05:00
forgejo/web_src/js/features
oliverpool 715bedbde7 [BUG] admin authentication source JS errors (#4059)
While trying to understand #1236, I was quite confused not to see the `Use Custom URLs` checkbox.

This checkbox disappeared in b95a893b22 (because `getElementById` does not expect a `#` as first char), fixed in 4e816e1326.

After solving this, switching from `Nextcloud` to `OpenID Connect` triggered a JS error, which is addressed in 3efa4d836a.

Manual testing:
- go to http://localhost:3000/admin/auths
- click on `Add authentication source`
- Choose `Authentication type`: `OAuth2`
- Choose `OAuth2 provider`: `Nextcloud`
- check that the `Use Custom URLs Instead of Default URLs` checkbox toggles the fields below
- let the checkbox be checked
- Switch the `OAuth2 provider` to `OpenID Connect`
- ensure that no JS error is shown
- Switch the `OAuth2 provider` to `Mastodon`
- check that the fields below `Use Custom URLs Instead of Default URLs` have the right defaults (mastodon.social)

![2024-06-07-101638.png](/attachments/5bd6692e-3457-4dd8-b1c1-50e9a95a3100)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4059
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
(cherry picked from commit 82ae7460bf)
2024-06-17 10:06:34 +00:00
..
admin [BUG] admin authentication source JS errors (#4059) 2024-06-17 10:06:34 +00:00
comp s/Gitea/Forgejo in various log messages and comments 2024-04-22 14:41:17 +00:00
autofocus-end.js When the title in the issue has a value, set the text cursor at the end of the text. (#30090) 2024-03-30 07:17:31 +01:00
captcha.js
citation.js
clipboard.js
code-frequency.js
codeeditor.js Disable enter key for accepting code completion in Monaco (#30548) (#30559) 2024-04-21 18:11:02 +02:00
colorpicker.js
common-global.js Remove fomantic checkbox module (#30162) (#30168) 2024-04-08 11:28:31 +02:00
common-issue-list.js
common-issue-list.test.js
common-organization.js
contextpopup.js
contributors.js
copycontent.js
dropzone.js
emoji.js
eventsource.sharedworker.js
file-fold.js
heatmap.js
imagediff.js
install.js
notification.js
org-team.js Remove jQuery calls that have no effect on showElem and hideElem (#30110) 2024-03-30 07:17:30 +01:00
pull-view-file.js
recent-commits.js
repo-branch.js Remove jQuery from the create/rename branch modals (except Fomantic) (#30109) 2024-03-30 07:17:31 +01:00
repo-code.js
repo-code.test.js
repo-commit.js
repo-common.js Refactor and fix archive link bug (#30535) 2024-05-14 08:34:46 +02:00
repo-diff-commit.js
repo-diff-commitselect.js
repo-diff-filetree.js
repo-diff.js
repo-editor.js Remove jQuery calls that have no effect on showElem and hideElem (#30110) 2024-03-30 07:17:30 +01:00
repo-findfile.js
repo-findfile.test.js
repo-graph.js
repo-home.js
repo-issue-content.js
repo-issue-list.js Drag-and-drop improvements for projects and issue pins (#29875) 2024-03-30 07:17:31 +01:00
repo-issue-pr-form.js
repo-issue-pr-status.js
repo-issue.js Fix an incorrect form submission in repo-issue.js (#3675) 2024-05-08 21:16:08 +00:00
repo-legacy.js [PORT] Refactor dropzone (#30232) 2024-04-08 09:50:53 +00:00
repo-migrate.js
repo-migration.js
repo-projects.js Fix various problems around projects board view (#30696) 2024-05-14 15:51:15 +02:00
repo-release.js
repo-search.js
repo-settings.js
repo-template.js
repo-unicode-escape.js [v7.0/forgejo] Render inline file permalinks 2024-04-01 16:15:58 +02:00
repo-wiki.js
sshkey-helper.js
stopwatch.js
tablesort.js
tribute.js
user-auth-webauthn.js
user-auth.js
user-settings.js [v7.0/forgejo] Add optional pronoun field in user settings (#3076) 2024-04-06 13:23:43 +00:00