0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 00:44:15 -05:00
forgejo/modules/markup
João Tiago 2adc3a45fb
Fixes #27605: inline math blocks can't be preceeded/followed by alphanumerical characters (#30175)
- Inline math blocks couldn't be preceeded or succeeded by
alphanumerical characters due to changes introduced in PR #21171.
Removed the condition that caused this (precedingCharacter condition)
and added a new exit condition of the for-loop that checks if a specific
'$' was escaped using '\' so that the math expression can be rendered as
intended.
- Additionally this PR fixes another bug where math blocks of the type
'$xyz$abc$' where the dollar sign was not escaped by the user, generated
an error (shown in the screenshots below)
- Altered the tests to accomodate for the changes

Former behaviour (from try.gitea.io):

![image](https://github.com/go-gitea/gitea/assets/114936010/8f0cbb21-321d-451c-b871-c67a8e1e9235)

Fixed behaviour (from my local build):

![image](https://github.com/go-gitea/gitea/assets/114936010/5c22687c-6f11-4407-b5e7-c14b838bc20d)

(Edit) Source code for the README.md file:
```
$x$ -$x$ $x$-

a$xa$ $xa$a 1$xb$ $xb$1

$a a$b b$

a$b $a a$b b$

$a a\$b b$
```

---------

Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit e006451ab1509f8d6d43c5974387c05b26517392)
2024-04-07 15:40:31 +02:00
..
asciicast
common [GITEA] test markdown CleanValue to prevent regression 2024-02-05 16:09:41 +01:00
console
csv Fix some pending problems (#29985) 2024-03-26 19:04:26 +01:00
external
markdown Fixes #27605: inline math blocks can't be preceeded/followed by alphanumerical characters (#30175) 2024-04-07 15:40:31 +02:00
mdstripper
orgmode [BUG] Fix relative links on orgmode 2024-02-18 21:09:35 +01:00
tests/repo/repo1_filepreview Update test 2024-03-28 04:20:13 +01:00
camo.go
camo_test.go
file_preview.go Fix formating & remove commented out code 2024-03-27 18:43:55 +01:00
html.go [BUG] Fix crash in issue forms 2024-04-04 15:54:06 +02:00
html_internal_test.go Use relative links for commits, mentions, and issues in markdown (#29427) 2024-03-20 08:46:28 +01:00
html_test.go Merge pull request 'Render inline file permalinks' (#2669) from Mai-Lapyst/forgejo:markup-add-filepreview into forgejo 2024-04-01 13:57:01 +00:00
renderer.go Merge pull request 'Render inline file permalinks' (#2669) from Mai-Lapyst/forgejo:markup-add-filepreview into forgejo 2024-04-01 13:57:01 +00:00
renderer_test.go
sanitizer.go [BUG] Center icon and callout text 2024-04-03 22:26:19 +02:00
sanitizer_test.go