mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-27 09:54:15 -05:00
c53ad052d8
Some bugs caused by less unit tests in fundamental packages. This PR refactor `setting` package so that create a unit test will be easier than before. - All `LoadFromXXX` files has been splited as two functions, one is `InitProviderFromXXX` and `LoadCommonSettings`. The first functions will only include the code to create or new a ini file. The second function will load common settings. - It also renames all functions in setting from `newXXXService` to `loadXXXSetting` or `loadXXXFrom` to make the function name less confusing. - Move `XORMLog` to `SQLLog` because it's a better name for that. Maybe we should finally move these `loadXXXSetting` into the `XXXInit` function? Any idea? --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: delvh <dev.lh@web.de>
32 lines
903 B
Go
32 lines
903 B
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import "reflect"
|
|
|
|
// GetCronSettings maps the cron subsection to the provided config
|
|
func GetCronSettings(name string, config interface{}) (interface{}, error) {
|
|
return getCronSettings(CfgProvider, name, config)
|
|
}
|
|
|
|
func getCronSettings(rootCfg ConfigProvider, name string, config interface{}) (interface{}, error) {
|
|
if err := rootCfg.Section("cron." + name).MapTo(config); err != nil {
|
|
return config, err
|
|
}
|
|
|
|
typ := reflect.TypeOf(config).Elem()
|
|
val := reflect.ValueOf(config).Elem()
|
|
|
|
for i := 0; i < typ.NumField(); i++ {
|
|
field := val.Field(i)
|
|
tpField := typ.Field(i)
|
|
if tpField.Type.Kind() == reflect.Struct && tpField.Anonymous {
|
|
if err := rootCfg.Section("cron." + name).MapTo(field.Addr().Interface()); err != nil {
|
|
return config, err
|
|
}
|
|
}
|
|
}
|
|
|
|
return config, nil
|
|
}
|