mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-23 07:43:18 -05:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
68 lines
2.3 KiB
Handlebars
68 lines
2.3 KiB
Handlebars
<h4 class="ui top attached header">
|
|
{{.locale.Tr "secrets.secrets"}}
|
|
<div class="ui right">
|
|
<button class="ui primary tiny show-panel button" data-panel="#add-secret-panel">{{.locale.Tr "secrets.creation"}}</button>
|
|
</div>
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
<div class="{{if not .HasError}}gt-hidden {{end}}gt-mb-4" id="add-secret-panel">
|
|
<form class="ui form" action="{{.Link}}" method="post">
|
|
{{.CsrfTokenHtml}}
|
|
<div class="field">
|
|
{{.locale.Tr "secrets.description"}}
|
|
</div>
|
|
<div class="field{{if .Err_Title}} error{{end}}">
|
|
<label for="secret-title">{{.locale.Tr "secrets.name"}}</label>
|
|
<input id="secret-title" name="title" value="{{.title}}" autofocus required pattern="^[a-zA-Z_][a-zA-Z0-9_]*$" placeholder="{{.locale.Tr "secrets.creation.name_placeholder"}}">
|
|
</div>
|
|
<div class="field{{if .Err_Content}} error{{end}}">
|
|
<label for="secret-content">{{.locale.Tr "secrets.value"}}</label>
|
|
<textarea id="secret-content" name="content" required placeholder="{{.locale.Tr "secrets.creation.value_placeholder"}}">{{.content}}</textarea>
|
|
</div>
|
|
<button class="ui green button">
|
|
{{.locale.Tr "secrets.creation"}}
|
|
</button>
|
|
<button class="ui hide-panel button" data-panel="#add-secret-panel">
|
|
{{.locale.Tr "cancel"}}
|
|
</button>
|
|
</form>
|
|
</div>
|
|
{{if .Secrets}}
|
|
<div class="ui key list">
|
|
{{range .Secrets}}
|
|
<div class="item">
|
|
<div class="right floated content">
|
|
<button class="ui red tiny button delete-button" data-url="{{$.Link}}/delete" data-id="{{.ID}}">
|
|
{{$.locale.Tr "settings.delete_key"}}
|
|
</button>
|
|
</div>
|
|
<div class="left floated content">
|
|
<i>{{svg "octicon-key" 32}}</i>
|
|
</div>
|
|
<div class="content">
|
|
<strong>{{.Name}}</strong>
|
|
<div class="print meta">******</div>
|
|
<div class="activity meta">
|
|
<i>
|
|
{{$.locale.Tr "settings.add_on"}}
|
|
<span>{{.CreatedUnix.FormatShort}}</span>
|
|
</i>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
{{else}}
|
|
{{.locale.Tr "secrets.none"}}
|
|
{{end}}
|
|
</div>
|
|
<div class="ui small basic delete modal">
|
|
<div class="ui header">
|
|
{{svg "octicon-trash" 16 "gt-mr-2"}}
|
|
{{.locale.Tr "secrets.deletion"}}
|
|
</div>
|
|
<div class="content">
|
|
<p>{{.locale.Tr "secrets.deletion.description"}}</p>
|
|
</div>
|
|
{{template "base/delete_modal_actions" .}}
|
|
</div>
|