mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-29 10:54:02 -05:00
d5fa2e7510
Fix #22581 TLDR: #18446 made a mess with ForeignIndex and triggered a design flaw/bug of #16356, then a quick patch #21271 helped #18446, then the the bug was re-triggered by #21721 . Related: * #16356 * BasicIssueContext https://github.com/go-gitea/gitea/pull/16356/files#diff-7938eb670d42a5ead6b08121e16aa4537a4d716c1cf37923c70470020fb9d036R16-R27 * #18446 * If some issues were dumped without ForeignIndex, then they would be imported as ForeignIndex=0 https://github.com/go-gitea/gitea/pull/18446/files#diff-1624a3e715d8fc70edf2db1630642b7d6517f8c359cc69d58c3958b34ba4ce5eR38-R39 * #21271 * It patched the above bug (somewhat), made the issues without ForeignIndex could have the same value as LocalIndex * #21721 * It re-triggered the zero-ForeignIndex bug. ps: I am not sure whether the changes in `GetForeignIndex` are ideal (at least, now it has almost the same behavior as BasicIssueContext in #16356), it's just a quick fix. Feel free to edit on this PR directly or replace it. Co-authored-by: zeripath <art27@cantab.net>
48 lines
1.8 KiB
Go
48 lines
1.8 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Copyright 2018 Jonas Franz. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package migration
|
|
|
|
import "time"
|
|
|
|
// Issue is a standard issue information
|
|
type Issue struct {
|
|
Number int64 `json:"number"`
|
|
PosterID int64 `yaml:"poster_id" json:"poster_id"`
|
|
PosterName string `yaml:"poster_name" json:"poster_name"`
|
|
PosterEmail string `yaml:"poster_email" json:"poster_email"`
|
|
Title string `json:"title"`
|
|
Content string `json:"content"`
|
|
Ref string `json:"ref"`
|
|
Milestone string `json:"milestone"`
|
|
State string `json:"state"` // closed, open
|
|
IsLocked bool `yaml:"is_locked" json:"is_locked"`
|
|
Created time.Time `json:"created"`
|
|
Updated time.Time `json:"updated"`
|
|
Closed *time.Time `json:"closed"`
|
|
Labels []*Label `json:"labels"`
|
|
Reactions []*Reaction `json:"reactions"`
|
|
Assignees []string `json:"assignees"`
|
|
ForeignIndex int64 `json:"foreign_id"`
|
|
Context DownloaderContext `yaml:"-"`
|
|
}
|
|
|
|
// GetExternalName ExternalUserMigrated interface
|
|
func (issue *Issue) GetExternalName() string { return issue.PosterName }
|
|
|
|
// GetExternalID ExternalUserMigrated interface
|
|
func (issue *Issue) GetExternalID() int64 { return issue.PosterID }
|
|
|
|
func (issue *Issue) GetLocalIndex() int64 { return issue.Number }
|
|
|
|
func (issue *Issue) GetForeignIndex() int64 {
|
|
// see the comment of Reviewable.GetForeignIndex
|
|
// if there is no ForeignIndex, then use LocalIndex
|
|
if issue.ForeignIndex == 0 {
|
|
return issue.Number
|
|
}
|
|
return issue.ForeignIndex
|
|
}
|
|
|
|
func (issue *Issue) GetContext() DownloaderContext { return issue.Context }
|