0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 07:13:02 -05:00
forgejo/modules
Giteabot 24cf06592e
Restrict [actions].DEFAULT_ACTIONS_URL to only github or self (#25581) (#25604)
Backport #25581 by @wolfogre

Resolve #24789

## ⚠️ BREAKING ⚠️

Before this, `DEFAULT_ACTIONS_URL` cound be set to any custom URLs like
`https://gitea.com` or `http://your-git-server,https://gitea.com`, and
the default value was `https://gitea.com`.

But now, `DEFAULT_ACTIONS_URL` supports only
`github`(`https://github.com`) or `self`(the root url of current Gitea
instance), and the default value is `github`.

If it has configured with a URL, an error log will be displayed and it
will fallback to `github`.

Actually, what we really want to do is always make it
`https://github.com`, however, this may not be acceptable for some
instances of internal use, so there's extra support for `self`, but no
more, even `https://gitea.com`.

Please note that `uses: https://xxx/yyy/zzz` always works and it does
exactly what it is supposed to do.

Although it's breaking, I belive it should be backported to `v1.20` due
to some security issues.

Follow-up on the runner side:

- https://gitea.com/gitea/act_runner/pulls/262
- https://gitea.com/gitea/act/pulls/70

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-30 07:53:00 +00:00
..
actions Fix content holes in Actions task logs file (#25560) (#25566) 2023-06-28 23:39:23 +00:00
activitypub
analyze
assetfs
auth
avatar Improve avatar uploading / resizing / compressing, remove Fomantic card module (#24653) 2023-05-13 20:59:11 +02:00
base
cache
charset
container
context Fix open redirect check for more cases (#25143) (#25154) 2023-06-08 18:03:42 +02:00
csv
doctor Refactor path & config system (#25330) (#25416) 2023-06-22 16:27:18 +00:00
emoji
eventsource
generate
git Fix index generation parallelly failure (#25235) (#25269) 2023-06-15 02:14:00 +00:00
gitgraph
graceful Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
hcaptcha
highlight
hostmatcher
html
httpcache Use standard HTTP library to serve files (#24693) 2023-05-13 16:04:57 +02:00
httplib Use standard HTTP library to serve files (#24693) 2023-05-13 16:04:57 +02:00
indexer Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
issue/template
json
label
lfs Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
log Fix sub-command log level (#25537) (#25553) 2023-06-28 17:35:20 +08:00
markup Refactor path & config system (#25330) (#25416) 2023-06-22 16:27:18 +00:00
mcaptcha
metrics Use a separate admin page to show global stats, remove actions stat (#25062) 2023-06-03 22:03:41 +08:00
migration
mirror Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
nosql
notification Add Adopt repository event and handler (#25497) (#25518) 2023-06-26 20:09:07 +00:00
options
packages Add CRAN package registry (#22331) 2023-05-22 10:57:49 +08:00
paginator
pprof
private Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
process Do not output "Trace" level logs from process manager by default (#24952) 2023-05-27 10:55:24 +00:00
proxy
proxyprotocol
public Use standard HTTP library to serve files (#24693) 2023-05-13 16:04:57 +02:00
queue Help to recover from corrupted levelqueue (#24912) 2023-05-29 10:52:32 +08:00
recaptcha
references
regexplru
repository Remove stars when repo goes private (#19904) 2023-06-05 13:25:43 +00:00
secret Improve decryption failure message (#24573) 2023-05-07 19:29:43 +08:00
session
setting Restrict [actions].DEFAULT_ACTIONS_URL to only github or self (#25581) (#25604) 2023-06-30 07:53:00 +00:00
sitemap
ssh Fix incorrect config argument position for builtin SSH server (#25341) 2023-06-18 16:56:21 +00:00
storage Fix all possible setting error related storages and added some tests (#23911) (#25244) 2023-06-14 08:36:52 +02:00
structs Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
svg Use inline SVG for built-in OAuth providers (#25171) (#25234) 2023-06-13 12:04:40 +00:00
sync
system
templates Fix missing commit message body when the message has leading newlines (#25418) (#25422) 2023-06-21 13:55:08 +02:00
test Fix admin config page error, use tests to cover the admin config and 500 error page (#24965) 2023-05-29 15:00:21 +00:00
testlogger Refactor path & config system (#25330) (#25416) 2023-06-22 16:27:18 +00:00
timeutil Fix incorrect webhook time and use relative-time to display it (#24477) 2023-05-03 19:53:43 -04:00
translation Refactor INI package (first step) (#25024) 2023-06-02 17:27:30 +08:00
turnstile
typesniffer
updatechecker
upload
uri
user
util Move some regexp out of functions (#25430) (#25445) 2023-06-22 16:01:54 +00:00
validation
web Fix install page context, make the install page tests really test (#24858) 2023-05-23 09:29:15 +08:00
webhook New webhook trigger for receiving Pull Request review requests (#24481) 2023-05-24 22:06:27 -04:00