0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 00:44:15 -05:00
forgejo/modules/structs
Giteabot 203fe2841d
Fix Permission in API returned repository struct (#25388) (#25441)
Backport #25388 by @wolfogre

The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.

Co-authored-by: Jason Song <i@wolfogre.com>
2023-06-22 17:01:42 +02:00
..
activity.go Add activity feeds API (#23494) 2023-04-04 21:35:31 +08:00
activitypub.go
admin_user.go
attachment.go
commit_status.go
cron.go
doc.go
fork.go
git_blob.go
git_hook.go
hook.go New webhook trigger for receiving Pull Request review requests (#24481) 2023-05-24 22:06:27 -04:00
issue.go Add the ability to pin Issues (#24406) 2023-05-25 15:17:19 +02:00
issue_comment.go
issue_label.go Add API for Label templates (#24602) 2023-05-23 18:10:23 +08:00
issue_milestone.go
issue_reaction.go
issue_stopwatch.go
issue_test.go
issue_tracked_time.go
lfs_lock.go
mirror.go
miscellaneous.go Add API for gitignore templates (#22783) 2023-04-27 11:51:20 +08:00
nodeinfo.go
notifications.go
org.go Fix Org edit page bugs: renaming detection, maxlength (#24161) 2023-04-17 11:35:57 -04:00
org_member.go
org_team.go
package.go
pull.go Add the ability to pin Issues (#24406) 2023-05-25 15:17:19 +02:00
pull_review.go
release.go
repo.go Fix Permission in API returned repository struct (#25388) (#25441) 2023-06-22 17:01:42 +02:00
repo_branch.go
repo_collaborator.go
repo_commit.go
repo_file.go fix swagger documentation for multiple files API endpoint (#25110) 2023-06-07 23:49:58 +08:00
repo_key.go
repo_note.go
repo_refs.go
repo_tag.go
repo_topic.go
repo_tree.go
repo_watch.go
repo_wiki.go
settings.go
status.go
task.go Make repo migration cancelable and fix various bugs (#24605) 2023-05-11 08:25:46 +00:00
user.go
user_app.go
user_email.go
user_gpgkey.go
user_key.go
visible_type.go