0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 23:33:15 -05:00
forgejo/models/migrations/v1_17
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
main_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v211.go Drop migration for ForeignReference (#23605) 2023-03-23 15:01:55 -04:00
v212.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v213.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v214.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v215.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v216.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
v217.go Refactor setting.Database.UseXXX to methods (#23354) 2023-03-07 18:51:06 +08:00
v218.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v219.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v220.go [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00
v221.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v221_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v222.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v223.go [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00