Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 07:43:18 -05:00
Code Issues Activity
forgejo/templates/user/settings
History
Hester Gong 476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097) 
Co-Author: @wxiaoguang 

This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))

And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:

1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText

2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.

3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.

4. Also use the template for PR deletion modal and remove issue
dependency modal.

5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`

After (Also tested on arc green):

Hovering on the left buttons

<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">

<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">

Test for functionalities:

https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-04-23 17:24:19 +08:00
..
security Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
account.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
appearance.tmpl Add tooltips to Hide comment type settings where necessary (#21306) 2023-04-12 19:59:17 +08:00
applications.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
applications_oauth2.tmpl
applications_oauth2_edit.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
applications_oauth2_edit_form.tmpl
applications_oauth2_list.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
grants_oauth2.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
hook_new.tmpl Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
hooks.tmpl Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
keys.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
keys_gpg.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
keys_principal.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
keys_ssh.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
navbar.tmpl Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
organization.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
packages.tmpl Add Chef package registry (#22554) 2023-02-06 09:49:21 +08:00
packages_cleanup_rules_edit.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
packages_cleanup_rules_preview.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
profile.tmpl Limit avatar upload to valid image files (#24258) 2023-04-21 17:58:59 -04:00
repos.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
secrets.tmpl Add user secrets (#22191) 2023-02-01 20:53:04 +08:00