Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 08:06:49 -05:00
Code Issues Activity
forgejo/templates/repo
History
Hester Gong 476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097) 
Co-Author: @wxiaoguang 

This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))

And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:

1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText

2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.

3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.

4. Also use the template for PR deletion modal and remove issue
dependency modal.

5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`

After (Also tested on arc green):

Hovering on the left buttons

<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">

<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">

Test for functionalities:

https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-04-23 17:24:19 +08:00
..
actions Add runner check in repo action page (#24124) 2023-04-19 20:51:20 +08:00
branch Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
cite Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
diff Fix issue attachment handling (#24202) 2023-04-20 02:39:44 -04:00
editor Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
find Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
graph Improve template helper functions: string/slice (#24266) 2023-04-22 14:16:22 -04:00
issue Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
migrate Group template helper functions, remove Printf, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
projects Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
pulls Discolor pull request tab labels (#23950) 2023-04-07 15:12:45 -04:00
release Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
settings Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
wiki Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
activity.tmpl Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
blame.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
branch_dropdown.tmpl Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00
clone_buttons.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
clone_script.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
commit_page.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
commit_status.tmpl Use different SVG for pending and running actions (#23836) 2023-03-31 17:24:39 +08:00
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
commits.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
commits_list.tmpl Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
commits_list_small.tmpl Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
commits_table.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
create.tmpl Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
create_helper.tmpl Add templates to customize text when creating and migrating repositories 2023-01-24 22:36:48 -05:00
empty.tmpl Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
file_info.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
forks.tmpl Remove fomantic ".link" selector and styles (#23888) 2023-04-03 20:47:23 -04:00
graph.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
header.tmpl Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
home.tmpl Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
icon.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
packages.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
search.tmpl Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
search_name.tmpl Clean template/helper.go (#23922) 2023-04-07 03:31:41 -04:00
shabox_badge.tmpl Fix shabox regression (#22924) 2023-02-16 09:37:11 +08:00
sub_menu.tmpl Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
unicode_escape_prompt.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
upload.tmpl
user_cards.tmpl Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
view_file.tmpl Use a general Eval function for expressions in templates. (#23927) 2023-04-07 21:25:49 +08:00
view_list.tmpl Add wrapper to author to avoid long name ui problem (#23030) 2023-02-23 14:28:18 -06:00
watchers.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00